Skip to content

chore: Adds sentry APM #4698

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 2, 2020
Merged

Conversation

divs4debu
Copy link
Contributor

Fixes #4256

Short description of what this resolves:

Changes proposed in this pull request:

Checklist

  • I have read the Contribution & Best practices Guide.
  • My branch is up-to-date with the Upstream development branch.
  • The acceptance, integration, unit tests and linter pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@vercel
Copy link

vercel bot commented Aug 1, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/eventyay/open-event-frontend/ms7ccur1r
✅ Preview: https://open-event-frontend-git-fork-divs4debu-sentrytrace.eventyay.vercel.app

Copy link
Member

Codacy Here is an overview of what got changed by this pull request:

Issues
======
+ Solved 1
- Added 8
           

Complexity increasing per file
==============================
- config/environment.js  1
         

See the complete overview on Codacy

],
tracesSampleRate: config.sentry.tracesSampleRate,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codacy found an issue: Trailing spaces not allowed.

@@ -10,8 +11,10 @@ if (!config.sentry.dsn.includes('dummy')) {
new Dedupe(),
new CaptureConsole({
levels: ['error']
})
}),
new ApmIntegrations.Tracing(),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codacy found an issue: Unexpected trailing comma.

@@ -57,7 +57,8 @@ module.exports = function(environment) {
sentry: {
dsn : process.env.SENTRY_DSN || 'https://dummy@getsentry.com/dummy',
debug : !!process.env.SENTRY_DSN,
development : !process.env.SENTRY_DSN
development : !process.env.SENTRY_DSN,
tracesSampleRate: process.env.SENTRY_TRACE_SAMPLE_RATE || 0.01,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

],
tracesSampleRate: config.sentry.tracesSampleRate,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@@ -57,7 +57,8 @@ module.exports = function(environment) {
sentry: {
dsn : process.env.SENTRY_DSN || 'https://dummy@getsentry.com/dummy',
debug : !!process.env.SENTRY_DSN,
development : !process.env.SENTRY_DSN
development : !process.env.SENTRY_DSN,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@@ -10,8 +11,10 @@ if (!config.sentry.dsn.includes('dummy')) {
new Dedupe(),
new CaptureConsole({
levels: ['error']
})
}),
new ApmIntegrations.Tracing(),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@@ -10,8 +11,10 @@ if (!config.sentry.dsn.includes('dummy')) {
new Dedupe(),
new CaptureConsole({
levels: ['error']
})
}),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@@ -57,7 +57,8 @@ module.exports = function(environment) {
sentry: {
dsn : process.env.SENTRY_DSN || 'https://dummy@getsentry.com/dummy',
debug : !!process.env.SENTRY_DSN,
development : !process.env.SENTRY_DSN
development : !process.env.SENTRY_DSN,
tracesSampleRate: process.env.SENTRY_TRACE_SAMPLE_RATE || 0.01,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codacy found an issue: Unexpected trailing comma.

@codecov
Copy link

codecov bot commented Aug 1, 2020

Codecov Report

Merging #4698 into development will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           development    #4698   +/-   ##
============================================
  Coverage        23.11%   23.11%           
============================================
  Files              476      476           
  Lines             4975     4975           
  Branches             8        8           
============================================
  Hits              1150     1150           
  Misses            3824     3824           
  Partials             1        1           
Impacted Files Coverage Δ
app/sentry.ts 0.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b9929ad...21576eb. Read the comment docs.

@iamareebjamal iamareebjamal merged commit dabf4bd into fossasia:development Aug 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Integrate Sentry APM tracing
3 participants