-
Notifications
You must be signed in to change notification settings - Fork 1.8k
chore: Adds sentry APM #4698
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Adds sentry APM #4698
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/eventyay/open-event-frontend/ms7ccur1r |
Issues
======
+ Solved 1
- Added 8
Complexity increasing per file
==============================
- config/environment.js 1
See the complete overview on Codacy |
], | ||
tracesSampleRate: config.sentry.tracesSampleRate, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Codacy found an issue: Trailing spaces not allowed.
@@ -10,8 +11,10 @@ if (!config.sentry.dsn.includes('dummy')) { | |||
new Dedupe(), | |||
new CaptureConsole({ | |||
levels: ['error'] | |||
}) | |||
}), | |||
new ApmIntegrations.Tracing(), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Codacy found an issue: Unexpected trailing comma.
@@ -57,7 +57,8 @@ module.exports = function(environment) { | |||
sentry: { | |||
dsn : process.env.SENTRY_DSN || 'https://dummy@getsentry.com/dummy', | |||
debug : !!process.env.SENTRY_DSN, | |||
development : !process.env.SENTRY_DSN | |||
development : !process.env.SENTRY_DSN, | |||
tracesSampleRate: process.env.SENTRY_TRACE_SAMPLE_RATE || 0.01, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Codacy found an issue: Missing space after key 'tracesSampleRate'.
], | ||
tracesSampleRate: config.sentry.tracesSampleRate, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Codacy found an issue: Expected indentation of 4 spaces but found 8.
@@ -57,7 +57,8 @@ module.exports = function(environment) { | |||
sentry: { | |||
dsn : process.env.SENTRY_DSN || 'https://dummy@getsentry.com/dummy', | |||
debug : !!process.env.SENTRY_DSN, | |||
development : !process.env.SENTRY_DSN | |||
development : !process.env.SENTRY_DSN, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Codacy found an issue: Missing space after key 'development'.
@@ -10,8 +11,10 @@ if (!config.sentry.dsn.includes('dummy')) { | |||
new Dedupe(), | |||
new CaptureConsole({ | |||
levels: ['error'] | |||
}) | |||
}), | |||
new ApmIntegrations.Tracing(), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Codacy found an issue: Expected indentation of 6 spaces but found 12.
@@ -10,8 +11,10 @@ if (!config.sentry.dsn.includes('dummy')) { | |||
new Dedupe(), | |||
new CaptureConsole({ | |||
levels: ['error'] | |||
}) | |||
}), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Codacy found an issue: Expected indentation of 6 spaces but found 12.
@@ -57,7 +57,8 @@ module.exports = function(environment) { | |||
sentry: { | |||
dsn : process.env.SENTRY_DSN || 'https://dummy@getsentry.com/dummy', | |||
debug : !!process.env.SENTRY_DSN, | |||
development : !process.env.SENTRY_DSN | |||
development : !process.env.SENTRY_DSN, | |||
tracesSampleRate: process.env.SENTRY_TRACE_SAMPLE_RATE || 0.01, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Codacy found an issue: Unexpected trailing comma.
Codecov Report
@@ Coverage Diff @@
## development #4698 +/- ##
============================================
Coverage 23.11% 23.11%
============================================
Files 476 476
Lines 4975 4975
Branches 8 8
============================================
Hits 1150 1150
Misses 3824 3824
Partials 1 1
Continue to review full report at Codecov.
|
Fixes #4256
Short description of what this resolves:
Changes proposed in this pull request:
Checklist
development
branch.