Skip to content

feat: Implement event publish-unpublish confirm pop-up #4655

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

Haider8
Copy link
Contributor

@Haider8 Haider8 commented Jul 28, 2020

Fixes #4621

Short description of what this resolves:

There was no confirmation when user publish or unpublish his/her event.

Changes proposed in this pull request:

Show confirmation pop-up whenever user tries to publish or unpublish his/her event.

publish-unpublish-confirm

Checklist

  • I have read the Contribution & Best practices Guide.
  • My branch is up-to-date with the Upstream development branch.
  • The acceptance, integration, unit tests and linter pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@vercel
Copy link

vercel bot commented Jul 28, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/eventyay/open-event-frontend/p60eub4kv
✅ Preview: https://open-event-frontend-git-fork-haider8-confirm-publish-unpublish.eventyay.vercel.app

@codecov
Copy link

codecov bot commented Jul 28, 2020

Codecov Report

Merging #4655 into development will decrease coverage by 0.01%.
The diff coverage is 0.00%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #4655      +/-   ##
===============================================
- Coverage        23.08%   23.06%   -0.02%     
===============================================
  Files              475      476       +1     
  Lines             4952     4955       +3     
  Branches             8        8              
===============================================
  Hits              1143     1143              
- Misses            3808     3811       +3     
  Partials             1        1              
Impacted Files Coverage Δ
app/components/modals/publish-unpublish-modal.js 0.00% <0.00%> (ø)
app/controllers/events/view.js 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1c8ee53...f650b43. Read the comment docs.

@iamareebjamal iamareebjamal changed the title enh: Implement event publish-unpublish confirm pop-up feat: Implement event publish-unpublish confirm pop-up Jul 29, 2020
@auto-label auto-label bot added the feature label Jul 29, 2020
@iamareebjamal
Copy link
Member

Please mark new additions as feat:

@iamareebjamal iamareebjamal merged commit 3eb90be into fossasia:development Jul 29, 2020
@Haider8 Haider8 deleted the confirm-publish-unpublish branch July 29, 2020 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Publish/Unpublish: Show pop-up to confirm choice
2 participants