Skip to content

fix: visibility of custom form field and info text color #4645

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jul 28, 2020
Merged

fix: visibility of custom form field and info text color #4645

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
ce923f9
social links fixed text
ruhci28 Jul 27, 2020
e8c1fe2
make custom form field visible on attendee form turn on and change co…
ruhci28 Jul 27, 2020
bfa95dd
change text color under info about attendee
ruhci28 Jul 27, 2020
caabe92
remove unneccary changes
ruhci28 Jul 27, 2020
510d394
unneccary if condition remove
ruhci28 Jul 28, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/styles/libs/_helpers.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ $spacer-heights: 50 100 200 300 400 500 600 700 800 900;
}

.text.muted {
color: #aeaeae !important;
color: #888 !important;
}

.text.center.aligned {
Expand Down
10 changes: 5 additions & 5 deletions app/templates/components/forms/wizard/attendee-step.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,12 +91,12 @@
</table>
</div>
</div>
<Forms::Wizard::CustomFormInput
@newFormField={{this.data.newFormField}}
@customForms={{this.data.customForms}}
@event={{this.data.event}}
@form="attendee" />
{{/if}}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why add one more if and nor just move it inside the if above?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

<Forms::Wizard::CustomFormInput
@newFormField={{this.data.newFormField}}
@customForms={{this.data.customForms}}
@event={{this.data.event}}
@form="attendee" />
<div class="spacer-50"></div>
<div class="{{if this.device.isMobile 'mini four' 'right floated large'}} ui fields buttons">
<button class="ui three field left labeled icon button {{if this.isLoading 'disabled'}}" type="button" {{action 'move' 'backwards'}}>
Expand Down