Skip to content

feat: add instagram social link #4637

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 26, 2020

Conversation

snitin315
Copy link
Member

@snitin315 snitin315 commented Jul 26, 2020

Short description of what this resolves:

Fixes #4617

Requires fossasia/open-event-server#7163

Changes proposed in this pull request:

  • Added field for the Instagram social link.
  • rename google + to google group in URL.

Screenshot at 2020-07-26 08-45-54

Unfortunately, Semantic UI doesn't have an icon for google-groups. I'm finding a suitable icon and will update.

Checklist

  • I have read the Contribution & Best practices Guide.
  • My branch is up-to-date with the Upstream development branch.
  • The acceptance, integration, unit tests and linter pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@vercel
Copy link

vercel bot commented Jul 26, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/eventyay/open-event-frontend/j571mazn7
✅ Preview: https://open-event-frontend-git-fork-snitin315-feat-instagram.eventyay.vercel.app

@niranjan94
Copy link
Member

Codacy Here is an overview of what got changed by this pull request:

Issues
======
+ Solved 1
           

See the complete overview on Codacy

@codecov
Copy link

codecov bot commented Jul 26, 2020

Codecov Report

Merging #4637 into development will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           development    #4637   +/-   ##
============================================
  Coverage        22.90%   22.90%           
============================================
  Files              472      472           
  Lines             4978     4978           
  Branches             8        8           
============================================
  Hits              1140     1140           
  Misses            3837     3837           
  Partials             1        1           
Impacted Files Coverage Δ
...omponents/forms/admin/content/social-links-form.js 0.00% <ø> (ø)
app/routes/create.js 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 549270c...e7b8756. Read the comment docs.

@iamareebjamal iamareebjamal marked this pull request as ready for review July 26, 2020 04:24
@iamareebjamal iamareebjamal merged commit 5227cb7 into fossasia:development Jul 26, 2020
@snitin315 snitin315 deleted the feat/instagram branch July 26, 2020 04:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Admin Social Links (System): Change Google+ Icon to Google Groups Icon and add Instagram
3 participants