Skip to content

fix: Change default pre-selected fields in wizard step 4 #4603

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 22, 2020

Conversation

Haider8
Copy link
Contributor

@Haider8 Haider8 commented Jul 22, 2020

Fixes #4586

Short description of what this resolves:

Session and speaker custom forms have few fields pre-selected for new events in wizard step 4.

Changes proposed in this pull request:

Change default pre-selected fields

default-pre-selected-fields

Checklist

  • I have read the Contribution & Best practices Guide.
  • My branch is up-to-date with the Upstream development branch.
  • The acceptance, integration, unit tests and linter pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@vercel
Copy link

vercel bot commented Jul 22, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/eventyay/open-event-frontend/5y5m1ooxm
✅ Preview: https://open-event-frontend-git-fork-haider8-pre-selected-fields.eventyay.vercel.app

@codecov
Copy link

codecov bot commented Jul 22, 2020

Codecov Report

Merging #4603 into development will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           development    #4603   +/-   ##
============================================
  Coverage        22.27%   22.27%           
============================================
  Files              474      474           
  Lines             4988     4988           
  Branches             8        8           
============================================
  Hits              1111     1111           
  Misses            3876     3876           
  Partials             1        1           
Impacted Files Coverage Δ
app/mixins/custom-form.js 0.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 336923a...dd47aaa. Read the comment docs.

isFixed : true,
isRequired : false,
isIncluded : false,
isFixed : false,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Track optional is not implemented on server yet. Revert to previous state

@iamareebjamal iamareebjamal merged commit 3ba9b1a into fossasia:development Jul 22, 2020
@Haider8 Haider8 deleted the pre-selected-fields branch July 22, 2020 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Session and Speakers form in Wizard Step 4 have a few fields pre-selected which are not necessary to be pre-selected
2 participants