Skip to content

fix: Add location required error message in wizard step 1 #4602

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

Haider8
Copy link
Contributor

@Haider8 Haider8 commented Jul 22, 2020

Fixes #4585

Short description of what this resolves:

No error message was shown to the user regarding required event location in event create wizard step 1.

Changes proposed in this pull request:

Show error message if the user tries to save an event without entering event location.

location-required

Checklist

  • I have read the Contribution & Best practices Guide.
  • My branch is up-to-date with the Upstream development branch.
  • The acceptance, integration, unit tests and linter pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@vercel
Copy link

vercel bot commented Jul 22, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/eventyay/open-event-frontend/fabos0uor
✅ Preview: https://open-event-frontend-git-fork-haider8-location-required-message.eventyay.vercel.app

@Haider8 Haider8 requested a review from iamareebjamal July 22, 2020 09:35
@Haider8 Haider8 changed the title Add location required error message in wizard step 1 fix: Add location required error message in wizard step 1 Jul 22, 2020
@auto-label auto-label bot added the fix label Jul 22, 2020
Copy link
Member

@iamareebjamal iamareebjamal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect. Thank You

@codecov
Copy link

codecov bot commented Jul 22, 2020

Codecov Report

Merging #4602 into development will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           development    #4602   +/-   ##
============================================
  Coverage        22.27%   22.27%           
============================================
  Files              474      474           
  Lines             4988     4988           
  Branches             8        8           
============================================
  Hits              1111     1111           
  Misses            3876     3876           
  Partials             1        1           
Impacted Files Coverage Δ
app/components/forms/wizard/basic-details-step.js 24.69% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d832aee...8a4aa50. Read the comment docs.

@iamareebjamal iamareebjamal merged commit 336923a into fossasia:development Jul 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wizard Step 1: If organizer does not enter location, there is no error message indicating why event cannot be saved
3 participants