Skip to content

fix: Filter attendee form from all custom forms #4601

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

iamareebjamal
Copy link
Member

@iamareebjamal iamareebjamal commented Jul 21, 2020

Fixes #4597

Ember Data strikes again. There is a custom function query used everywhere throughout the project which filters out the items from server. But ember data returns all the items from local in memory DB because how cool it is, and this custom query method does not take it into account. Hence, once all custom form fields are loaded in memory, it returns all the items rather than just the attendee custom form

@vercel
Copy link

vercel bot commented Jul 21, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/eventyay/open-event-frontend/5cdixluf6
✅ Preview: https://open-event-frontend-git-fork-iamareebjamal-attendee-form-filter.eventyay.vercel.app

@codecov
Copy link

codecov bot commented Jul 21, 2020

Codecov Report

Merging #4601 into development will decrease coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #4601      +/-   ##
===============================================
- Coverage        22.27%   22.27%   -0.01%     
===============================================
  Files              474      474              
  Lines             4987     4988       +1     
  Branches             8        8              
===============================================
  Hits              1111     1111              
- Misses            3875     3876       +1     
  Partials             1        1              
Impacted Files Coverage Δ
app/routes/events/view/edit/attendee.js 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6ac9896...7f8b96c. Read the comment docs.

@iamareebjamal iamareebjamal merged commit d832aee into fossasia:development Jul 21, 2020
@iamareebjamal iamareebjamal deleted the attendee-form-filter branch July 21, 2020 21:09
@mariobehling
Copy link
Member

OMG! Thanks for the fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Attendee Form: Editing the form sometimes suddenly shows field of speaker custom forms
2 participants