feat: Add field order to session and speaker forms #4579
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/eventyay/open-event-frontend/2medakpzl |
|
Issues
======
- Added 7
See the complete overview on Codacy |
niranjan94
reviewed
Jul 19, 2020
| test('test custom form fields sort', function(assert) { | ||
| const items = [{fieldIdentifier: 'age', isComplex: false}, {fieldIdentifier: 'job', isComplex: false}, {fieldIdentifier: 'majama', isComplex: true}, {fieldIdentifier: 'name', isComplex: false}, {fieldIdentifier: 'hay', isComplex: true}, {fieldIdentifier: 'trust', isComplex: false}, {fieldIdentifier: 'company', isComplex: false}]; | ||
| const order = ['name', 'age', 'company']; | ||
| assert.equal(JSON.stringify(sortCustomFormFields(items, order)), JSON.stringify([{fieldIdentifier:"name",isComplex:false},{fieldIdentifier:"age",isComplex:false},{fieldIdentifier:"company",isComplex:false},{fieldIdentifier:"job",isComplex:false},{fieldIdentifier:"trust",isComplex:false},{fieldIdentifier:"majama",isComplex:true},{fieldIdentifier:"hay",isComplex:true}])); |
There was a problem hiding this comment.
Codacy found an issue: Strings must use singlequote.
niranjan94
reviewed
Jul 19, 2020
| test('test custom form fields sort', function(assert) { | ||
| const items = [{fieldIdentifier: 'age', isComplex: false}, {fieldIdentifier: 'job', isComplex: false}, {fieldIdentifier: 'majama', isComplex: true}, {fieldIdentifier: 'name', isComplex: false}, {fieldIdentifier: 'hay', isComplex: true}, {fieldIdentifier: 'trust', isComplex: false}, {fieldIdentifier: 'company', isComplex: false}]; | ||
| const order = ['name', 'age', 'company']; | ||
| assert.equal(JSON.stringify(sortCustomFormFields(items, order)), JSON.stringify([{fieldIdentifier:"name",isComplex:false},{fieldIdentifier:"age",isComplex:false},{fieldIdentifier:"company",isComplex:false},{fieldIdentifier:"job",isComplex:false},{fieldIdentifier:"trust",isComplex:false},{fieldIdentifier:"majama",isComplex:true},{fieldIdentifier:"hay",isComplex:true}])); |
There was a problem hiding this comment.
Codacy found an issue: A space is required after ','.
niranjan94
reviewed
Jul 19, 2020
| test('test custom form fields sort', function(assert) { | ||
| const items = [{fieldIdentifier: 'age', isComplex: false}, {fieldIdentifier: 'job', isComplex: false}, {fieldIdentifier: 'majama', isComplex: true}, {fieldIdentifier: 'name', isComplex: false}, {fieldIdentifier: 'hay', isComplex: true}, {fieldIdentifier: 'trust', isComplex: false}, {fieldIdentifier: 'company', isComplex: false}]; | ||
| const order = ['name', 'age', 'company']; | ||
| assert.equal(JSON.stringify(sortCustomFormFields(items, order)), JSON.stringify([{fieldIdentifier:"name",isComplex:false},{fieldIdentifier:"age",isComplex:false},{fieldIdentifier:"company",isComplex:false},{fieldIdentifier:"job",isComplex:false},{fieldIdentifier:"trust",isComplex:false},{fieldIdentifier:"majama",isComplex:true},{fieldIdentifier:"hay",isComplex:true}])); |
There was a problem hiding this comment.
Codacy found an issue: Missing space before value for key 'fieldIdentifier'.
niranjan94
reviewed
Jul 19, 2020
|
|
||
| module('Unit | Sort | Custom Form Fields', function() { | ||
| test('test custom form fields sort', function(assert) { | ||
| const items = [{fieldIdentifier: 'age', isComplex: false}, {fieldIdentifier: 'job', isComplex: false}, {fieldIdentifier: 'majama', isComplex: true}, {fieldIdentifier: 'name', isComplex: false}, {fieldIdentifier: 'hay', isComplex: true}, {fieldIdentifier: 'trust', isComplex: false}, {fieldIdentifier: 'company', isComplex: false}]; |
There was a problem hiding this comment.
Codacy found an issue: A space is required after '{'.
niranjan94
reviewed
Jul 19, 2020
|
|
||
| export function sortCustomFormFields(fields: CustomFormField[], fieldOrder: string[]): CustomFormField[] { | ||
| fieldOrder = [...fieldOrder].reverse(); | ||
| return sortBy(fields, 'isComplex', item => -fieldOrder.indexOf(item.fieldIdentifier)); |
There was a problem hiding this comment.
Codacy found an issue: Expected indentation of 2 spaces but found 4.
niranjan94
reviewed
Jul 19, 2020
| } | ||
|
|
||
| export function sortCustomFormFields(fields: CustomFormField[], fieldOrder: string[]): CustomFormField[] { | ||
| fieldOrder = [...fieldOrder].reverse(); |
There was a problem hiding this comment.
Codacy found an issue: Expected indentation of 2 spaces but found 4.
niranjan94
reviewed
Jul 19, 2020
| test('test custom form fields sort', function(assert) { | ||
| const items = [{fieldIdentifier: 'age', isComplex: false}, {fieldIdentifier: 'job', isComplex: false}, {fieldIdentifier: 'majama', isComplex: true}, {fieldIdentifier: 'name', isComplex: false}, {fieldIdentifier: 'hay', isComplex: true}, {fieldIdentifier: 'trust', isComplex: false}, {fieldIdentifier: 'company', isComplex: false}]; | ||
| const order = ['name', 'age', 'company']; | ||
| assert.equal(JSON.stringify(sortCustomFormFields(items, order)), JSON.stringify([{fieldIdentifier:"name",isComplex:false},{fieldIdentifier:"age",isComplex:false},{fieldIdentifier:"company",isComplex:false},{fieldIdentifier:"job",isComplex:false},{fieldIdentifier:"trust",isComplex:false},{fieldIdentifier:"majama",isComplex:true},{fieldIdentifier:"hay",isComplex:true}])); |
There was a problem hiding this comment.
Codacy found an issue: A space is required after '{'.
Codecov Report
@@ Coverage Diff @@
## development #4579 +/- ##
===============================================
+ Coverage 22.21% 22.28% +0.07%
===============================================
Files 473 474 +1
Lines 4975 4985 +10
Branches 8 8
===============================================
+ Hits 1105 1111 +6
- Misses 3869 3873 +4
Partials 1 1
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3777