Skip to content

fix: Remove extra box around the GET URL on event export page #4467

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 17, 2020
Merged

fix: Remove extra box around the GET URL on event export page #4467

merged 3 commits into from
Jun 17, 2020

Conversation

ShreyanshSrivastava
Copy link
Contributor

@ShreyanshSrivastava ShreyanshSrivastava commented Jun 13, 2020

Fixes #4407

Short description of what this resolves:

My proposed code changes are fixing the extra box coming around the URL tab under GET request on the event export page.

Changes proposed in this pull request:

-Added classes .text .aligned .center styled in open-event-frontend.css to the div containing the url.
-Added classes .ui .basic .segments styled in open-event-frontend.css to the CopyButton containing
the URL.

                             ### **OLD VIEW**

Older-Version

                           ### **NEW VIEW**

Changed-Version

@vercel
Copy link

vercel bot commented Jun 13, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/eventyay/open-event-frontend/4xdcux0k2
✅ Preview: https://open-event-frontend-git-fork-shreyanshsrivastava-development.eventyay.vercel.app

@vercel vercel bot temporarily deployed to Preview June 13, 2020 11:26 Inactive
@ShreyanshSrivastava ShreyanshSrivastava changed the title Removed extra box around the GET URL one event export page Removed extra box around the GET URL on event export page #4407 Jun 13, 2020
@ShreyanshSrivastava ShreyanshSrivastava changed the title Removed extra box around the GET URL on event export page #4407 Removed extra box around the GET URL on event export page Jun 13, 2020
@codecov
Copy link

codecov bot commented Jun 13, 2020

Codecov Report

Merging #4467 into development will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           development    #4467   +/-   ##
============================================
  Coverage        22.28%   22.28%           
============================================
  Files              469      469           
  Lines             4950     4950           
  Branches             6        6           
============================================
  Hits              1103     1103           
  Misses            3846     3846           
  Partials             1        1           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 127f272...9967099. Read the comment docs.

…frontend into development

Keeping our remote repository in sync with the original repository
@iamareebjamal iamareebjamal changed the title Removed extra box around the GET URL on event export page fix: Remove extra box around the GET URL on event export page Jun 17, 2020
@auto-label auto-label bot added the fix label Jun 17, 2020
@iamareebjamal iamareebjamal merged commit 2b4a7b7 into fossasia:development Jun 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Event export page GET URL is surrounded by an unnecessary extra box
2 participants