Skip to content

fix: Replace Promise.allSettled by RSVP.allSettled #4408

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Jun 17, 2020
Merged

fix: Replace Promise.allSettled by RSVP.allSettled #4408

Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
ff70533
Replaced Promise.allSettled by RSVP.allSettled
EmperorYP7 May 26, 2020
36b5afc
minor fixes
EmperorYP7 May 26, 2020
635b78e
Fixed implementation of RSVP
EmperorYP7 May 27, 2020
27dced1
Merge branch 'development' into development
EmperorYP7 May 27, 2020
ba89a53
Merge branch 'development' into development
EmperorYP7 May 30, 2020
7913b49
minor fix
EmperorYP7 May 30, 2020
77ceb89
Merge branch 'development' into development
EmperorYP7 May 30, 2020
242d331
Merge branch 'development' into development
iamareebjamal Jun 17, 2020
4fcd28a
Update app/controllers/public/index.js
iamareebjamal Jun 17, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions app/mixins/event-wizard.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ export default Mixin.create(MutableArray, CustomFormMixin, {
async saveEventData(propsToSave = []) {
const { event } = this.model;
const data = {};
const results = await Promise.allSettled(propsToSave.map(property => {
const results = await RSVP.allSettled(propsToSave.map(property => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Return type of RSVP.allSettled is different from Promise.allSettled. Please fix the code accordingly

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried to get around this, sir. Do review it once. Any specific suggestion or resource to guide me through this?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Resolve conflicts and I will test the results

try {
return event.get(property);
} catch (e) {
Expand All @@ -59,7 +59,7 @@ export default Mixin.create(MutableArray, CustomFormMixin, {
}
}));
for (const [index, result] of results.entries()) {
if (result.status === 'fulfilled') {
if (result.state === 'fulfilled') {
const key = propsToSave[index];
data[key] = result.value;
}
Expand Down