Skip to content

feat: parallelize event overview api requests #4406

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 26, 2020

Conversation

abhinavk96
Copy link
Contributor

Reduces event overview page load time significantly, removes redundant promise for event details, as ember resolves models hierarchically, it's already resolved before the hook is called.

Fix for #4099

@vercel
Copy link

vercel bot commented May 26, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/eventyay/open-event-frontend/g4tu2l6bf
✅ Preview: https://open-event-frontend-git-fork-cosmiccoder96-parallel.eventyay.now.sh

@auto-label auto-label bot added the feature label May 26, 2020
@abhinavk96 abhinavk96 changed the title feat: parallize event overview api requests feat: parallelize event overview api requests May 26, 2020
@abhinavk96 abhinavk96 requested a review from iamareebjamal May 26, 2020 06:21
@codecov
Copy link

codecov bot commented May 26, 2020

Codecov Report

Merging #4406 into development will decrease coverage by 0.10%.
The diff coverage is 0.00%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #4406      +/-   ##
===============================================
- Coverage        22.68%   22.58%   -0.11%     
===============================================
  Files              468      468              
  Lines             4950     4960      +10     
  Branches             6        6              
===============================================
- Hits              1123     1120       -3     
- Misses            3826     3839      +13     
  Partials             1        1              
Impacted Files Coverage Δ
app/routes/events/view/index.js 0.00% <0.00%> (ø)
app/components/tabbed-navigation.js 33.33% <0.00%> (-20.00%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 366d144...0e80af9. Read the comment docs.

@abhinavk96
Copy link
Contributor Author

abhinavk96 commented May 26, 2020

@iamareebjamal allSettled is crashing the page. Checking, why.

@iamareebjamal
Copy link
Member

@vercel vercel bot temporarily deployed to Preview May 26, 2020 15:48 Inactive
@iamareebjamal iamareebjamal merged commit 671527e into fossasia:development May 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants