Skip to content

feat: Parallelize event page fetch #4400

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 23, 2020

Conversation

iamareebjamal
Copy link
Member

@iamareebjamal iamareebjamal commented May 23, 2020

Fetch infos about tickets, speakers, sessions, etc parallely.
Should be ideally done in their own components but OK for now
Also include event and tickets in discount code query

Fix for #4099

Fetch infos about tickets, speakers, sessions, etc parallely.
Should be ideally done in their own components but OK for now
Also include event and tickets in discount code query
@auto-label auto-label bot added the feature label May 23, 2020
@vercel
Copy link

vercel bot commented May 23, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/eventyay/open-event-frontend/350uoeblk
✅ Preview: https://open-event-frontend-git-fork-iamareebjamal-event-page-parallel.eventyay.now.sh

@codecov
Copy link

codecov bot commented May 23, 2020

Codecov Report

Merging #4400 into development will decrease coverage by 0.02%.
The diff coverage is 0.00%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #4400      +/-   ##
===============================================
- Coverage        22.63%   22.61%   -0.03%     
===============================================
  Files              468      468              
  Lines             4943     4949       +6     
  Branches             6        6              
===============================================
  Hits              1119     1119              
- Misses            3823     3829       +6     
  Partials             1        1              
Impacted Files Coverage Δ
app/components/public/ticket-list.js 17.69% <0.00%> (ø)
app/routes/public/index.js 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 523133f...91a10b6. Read the comment docs.

@iamareebjamal iamareebjamal merged commit 7be7058 into fossasia:development May 23, 2020
@iamareebjamal iamareebjamal deleted the event-page-parallel branch May 23, 2020 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant