Skip to content

chore: Upgrade semantic-ui-ember to 3.0.4 #4330

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 20, 2020

Conversation

iamareebjamal
Copy link
Member

@iamareebjamal iamareebjamal commented Apr 19, 2020

See #3872 #3902

#3901 and #3935 are issue with core semantic UI
They moved some icons to brand icons, and just "forgot" to add CSS for them. Let me see if it is fixed in fomantic UI or not. Else, it'll need to be fixed manually

@vercel
Copy link

vercel bot commented Apr 19, 2020

This pull request is being automatically deployed with ZEIT Now (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://zeit.co/eventyay/open-event-frontend/7fbgorofq
✅ Preview: https://open-event-frontend-git-fork-iamareebjamal-sui-ember.eventyay.now.sh

@codecov
Copy link

codecov bot commented Apr 20, 2020

Codecov Report

Merging #4330 into development will increase coverage by 0.06%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #4330      +/-   ##
===============================================
+ Coverage        22.72%   22.78%   +0.06%     
===============================================
  Files              468      468              
  Lines             4932     4932              
  Branches             5        5              
===============================================
+ Hits              1121     1124       +3     
+ Misses            3809     3806       -3     
  Partials             2        2              
Impacted Files Coverage Δ
app/services/auth-manager.js 58.62% <0.00%> (+5.17%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3f48c11...9a23232. Read the comment docs.

@iamareebjamal iamareebjamal merged commit df6bd8e into fossasia:development Apr 20, 2020
@iamareebjamal iamareebjamal deleted the sui-ember branch April 20, 2020 00:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant