Skip to content

fix: Changed the semantic class for the image in attendee and organizer app #4234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 16, 2020
Merged

fix: Changed the semantic class for the image in attendee and organizer app #4234

merged 2 commits into from
Mar 16, 2020

Conversation

Dishebh
Copy link
Member

@Dishebh Dishebh commented Mar 15, 2020

Fixes #3529

Short description of what this resolves:

Replaced fluid class with medium in attendee-app.hbs file.

Changes proposed in this pull request:

Checklist

  • I have read the Contribution & Best practices Guide.
  • My branch is up-to-date with the Upstream development branch.
  • The acceptance, integration, unit tests and linter pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@vercel
Copy link

vercel bot commented Mar 15, 2020 •
edited
Loading

This pull request is being automatically deployed with ZEIT Now (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://zeit.co/eventyay/open-event-frontend/qo23dbv1t
✅ Preview: https://open-event-frontend-git-fork-dishebh-patch-2.eventyay.now.sh

@iamareebjamal
Copy link
Member

When contributing in software, cheating is the key. See what's done in Organizer App section. Ctrl+C Ctrl+V and save your and reviewer's time :)

@codecov
Copy link

codecov bot commented Mar 15, 2020 •
edited
Loading

Codecov Report

Merging #4234 into development will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           development    #4234   +/-   ##
============================================
  Coverage        21.88%   21.88%           
============================================
  Files              461      461           
  Lines             4830     4830           
  Branches             5        5           
============================================
  Hits              1057     1057           
  Misses            3771     3771           
  Partials             2        2

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 89b93ac...ad6d013. Read the comment docs.

@Dishebh
Copy link
Member Author

Dishebh commented Mar 15, 2020

When contributing in software, cheating is the key. See what's done in Organizer App section. Ctrl+C Ctrl+V and save your and reviewer's time :)

Totally agree with you. But, in the organizer-app page, large is used instead of the medium which results in more unused space on the page. Pls refer the screenshots below for better picture:

  • for large:
    Screenshot from 2020-03-15 17-16-39

  • for medium:
    Screenshot from 2020-03-15 17-16-23

@Dishebh
Copy link
Member Author

Dishebh commented Mar 15, 2020

So, which one should I go for?

@iamareebjamal
Copy link
Member

Then change both

@Dishebh
Copy link
Member Author

Dishebh commented Mar 15, 2020

Then change both

Done.

@iamareebjamal
Copy link
Member

Follow PR title guidelines

@Dishebh
Copy link
Member Author

Dishebh commented Mar 15, 2020

Follow PR title guidelines

Can you pls share the link to refer?

@iamareebjamal
Copy link
Member

See any merged PR's title

@Dishebh Dishebh changed the title Fix: Removed fluid class in attendee-app.hbs Fix: Changed the semantic class for the image in attendee and organizer app Mar 16, 2020
@Dishebh
Copy link
Member Author

Dishebh commented Mar 16, 2020

See any merged PR's title

How about now?

@kushthedude kushthedude changed the title Fix: Changed the semantic class for the image in attendee and organizer app fix: Changed the semantic class for the image in attendee and organizer app Mar 16, 2020
@auto-label auto-label bot added the fix label Mar 16, 2020
@kushthedude kushthedude merged commit cbe1476 into fossasia:development Mar 16, 2020
@iamareebjamal
Copy link
Member

@kushthedude If we keep changing the title ourselves, they'll never learn how to copy guidelines of a particular project

@Dishebh
Copy link
Member Author

Dishebh commented Mar 16, 2020

@kushthedude If we keep changing the title ourselves, they'll never learn how to copy guidelines of a particular project

True! But, aren't both the titles same 😅

@Dishebh Dishebh deleted the patch-2 branch March 16, 2020 07:43
@snitin315
Copy link
Member

True! But, aren't both the titles same

Fix fix

@iamareebjamal
Copy link
Member

You're a programmer. Case matters

Dishebh added a commit to Dishebh/open-event-frontend that referenced this pull request Mar 29, 2020
@Dishebh
fix: Changed the semantic class for the image in attendee and organiz…
28b84a9 
…er app (fossasia#4234)

* Removed fluid class in attendee-app.hbs

* removed large class in organizer-app.hbs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kushthedude kushthedude kushthedude approved these changes

Assignees
No one assigned
Labels
fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Attendee Landing Page: Change the Semantic Class for the Image used
4 participants
@Dishebh @iamareebjamal @snitin315 @kushthedude