fix: incomprehensible snack bar message in the event details fragment #2833
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@iamareebjamal please review this |
|
Error shouldn't be shown |
I think the social links are not present in the database for that particular event and is the reason it is returning nothing, that is what I found in the logs. What do you think? @iamareebjamal |
|
Yes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2832
Fixed issue that is resulting in the incorrect message. The issue was in the getstring method that merges two strings given appropriate place holders. So instead of a string , an array of strings were passed as the second argument on which the toString() function is invoked resulting in that alien looking expression.
Screenshots for the change: