Skip to content

fix: Fixed the UI glitch that happens when the events fragment is refreshed. #2787

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 10 commits into
base: development
Choose a base branch
from
Open

fix: Fixed the UI glitch that happens when the events fragment is refreshed. #2787

wants to merge 10 commits into from

Conversation

@VamsiKrishnaCommits
Copy link
Contributor

Fixes #2786

Changes:
Now , on refresh , events are loaded right after the shimmer without the no-event placeholder coming in .

@VamsiKrishnaCommits VamsiKrishnaCommits changed the title Fixed the UI glitch that happens when the events fragment is refreshed. fix : Fixed the UI glitch that happens when the events fragment is refreshed. Oct 10, 2020
@VamsiKrishnaCommits VamsiKrishnaCommits changed the title fix : Fixed the UI glitch that happens when the events fragment is refreshed. fix: Fixed the UI glitch that happens when the events fragment is refreshed. Oct 10, 2020
@auto-label auto-label bot added the fix label Oct 10, 2020
liveHarshit
liveHarshit suggested changes Oct 13, 2020
View reviewed changes
Copy link
Member

@liveHarshit liveHarshit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can see the issue is closed (please add gif for before and after), and there are unnecessary changes, revert them

@VamsiKrishnaCommits
Copy link
Contributor Author

I can see the issue is closed (please add gif for before and after), and there are unnecessary changes, revert them

Yes will do that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@liveHarshit liveHarshit liveHarshit requested changes

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

fix

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

A UI glitch that happens in the events fragment when refreshed.

2 participants

@VamsiKrishnaCommits @liveHarshit