fix: Move viewLifeCycleOwner reference to onCreateView #2486
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
serializer
changed the title
|
|
||
| override fun onCreate(savedInstanceState: Bundle?) { | ||
| super.onCreate(savedInstanceState) | ||
| } |
There was a problem hiding this comment.
onCreate is redundant. Remove it
|
Search for other onCreates which might be referring to viewLifecycleOwner |
iamareebjamal
changed the title
iamareebjamal
approved these changes
Dec 10, 2019
rcs10
pushed a commit
to rcs10/open-event-attendee-android
that referenced
this pull request
Jun 18, 2020
Signed-off-by: rcs10 <dhanueshrc28@gmail.com>
rcs10
pushed a commit
to rcs10/open-event-attendee-android
that referenced
this pull request
Jun 18, 2020
Signed-off-by: rcs10 <dhanueshrc28@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2482
Changes: Instead of observing in onCreate method, I have observed the changes in onCreateView as the views get initialized after that in fragments.