Skip to content

Conversation

@Skrilltrax
Copy link

Fixes #1410

Changes: Converted gradle files to kotlin dsl syntax

Signed-off-by: Aditya Wasan <adityawasan55@gmail.com>
Signed-off-by: Aditya Wasan <adityawasan55@gmail.com>
Signed-off-by: Aditya Wasan <adityawasan55@gmail.com>
Signed-off-by: Aditya Wasan <adityawasan55@gmail.com>
Copy link
Member

@liveHarshit liveHarshit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

resolve conflicts

Signed-off-by: Aditya Wasan <adityawasan55@gmail.com>
Removed:

- local.properties gradle plugin
- AndroidConfig.kt
- KOTLIN_VERSION property

Signed-off-by: Aditya Wasan <adityawasan55@gmail.com>
@fossasia fossasia deleted a comment Sep 19, 2019
@fossasia fossasia deleted a comment Sep 19, 2019
@fossasia fossasia deleted a comment Sep 19, 2019
@fossasia fossasia deleted a comment Sep 19, 2019
@fossasia fossasia deleted a comment Sep 19, 2019
@fossasia fossasia deleted a comment Sep 19, 2019
@fossasia fossasia deleted a comment Sep 19, 2019
@fossasia fossasia deleted a comment Sep 19, 2019
@fossasia fossasia deleted a comment Sep 19, 2019
@fossasia fossasia deleted a comment Sep 19, 2019
@fossasia fossasia deleted a comment Sep 19, 2019
@fossasia fossasia deleted a comment Sep 19, 2019
@fossasia fossasia deleted a comment Sep 19, 2019
@fossasia fossasia deleted a comment Sep 19, 2019
@fossasia fossasia deleted a comment Sep 20, 2019
@Skrilltrax
Copy link
Author

@liveHarshit do i need to resolve codacy issues because most of the UnsafeCast are due to the return type being Any for the functions.

@liveHarshit
Copy link
Member

liveHarshit commented Sep 20, 2019

@liveHarshit do i need to resolve codacy issues because most of the UnsafeCast are due to the return type being Any for the functions.

You can fix them by using smart cast and removing non-null assertions.

@iamareebjamal
Copy link
Member

First goal should be passing build. Second would be polishing because the current library declarations are too verbose. We only want versions for libraries which have duplicate dependencies. We also don't know if dependabot supports this format. We can't lose auto dependency update functionality

@adityastic
Copy link
Contributor

@iamareebjamal dependabot currently does not support kts. The issue is opened since a year though https://github.com/dependabot/feedback/issues/172

@Skrilltrax
Copy link
Author

@iamareebjamal @adityastic so should I work on kts or close this PR and check groovy dependency management ?

@iamareebjamal
Copy link
Member

Leave it be. We'll iterate on it when the support is added

@Skrilltrax
Copy link
Author

@iamareebjamal sure, I'll just update the PR so to make sure it passes all the checks.

Signed-off-by: Aditya Wasan <adityawasan55@gmail.com>
@fossasia fossasia deleted a comment Sep 21, 2019
@fossasia fossasia deleted a comment Sep 21, 2019
@fossasia fossasia deleted a comment Sep 21, 2019
@fossasia fossasia deleted a comment Sep 21, 2019
@fossasia fossasia deleted a comment Sep 21, 2019
@fossasia fossasia deleted a comment Sep 21, 2019
@fossasia fossasia deleted a comment Sep 21, 2019
@fossasia fossasia deleted a comment Sep 21, 2019
@fossasia fossasia deleted a comment Sep 21, 2019
@fossasia fossasia deleted a comment Sep 21, 2019
@fossasia fossasia deleted a comment Sep 21, 2019
@fossasia fossasia deleted a comment Sep 21, 2019
@fossasia fossasia deleted a comment Sep 21, 2019
@fossasia fossasia deleted a comment Sep 21, 2019
Copy link
Member

@nikit19 nikit19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please resolve conflicts

//ExpandableView
implementation(Libs.expandablelayout)


Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

extra

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

Signed-off-by: Aditya Wasan <adityawasan55@gmail.com>
@fossasia fossasia deleted a comment Sep 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Maintainence] Make separate dependencies file for maintaining all dependencies/libraries

5 participants