fix: Feedback - button and crashes #2185
Conversation
|
Updated |
| <Button | ||
| <com.google.android.material.button.MaterialButton | ||
| android:id="@+id/feedbackBtn" | ||
| style="@style/ThreeDS2TextButtonStyle" |
There was a problem hiding this comment.
What does it do which is not in default style?
There was a problem hiding this comment.
It shows elevation and boundary line. Even if a transparent background is set.
There was a problem hiding this comment.
Merging this. But I see no documentation for this
There was a problem hiding this comment.
Found it. It is from the stripe library.
There was a problem hiding this comment.
Wow. Please revert it in the next development iteration ASAP.
There was a problem hiding this comment.
Wow. Please revert it in the next development iteration ASAP.
Sure 👍
| tools:visibility="visible"/> | ||
|
|
||
| <Button | ||
| <com.google.android.material.button.MaterialButton |
There was a problem hiding this comment.
Why? It happens automatically when android inflates the layout
app/src/main/res/values/strings.xml
Outdated
| <string name="what_type">What Sounds good?</string> | ||
| <string name="feedback">Feedback</string> | ||
| <string name="write_feedback">Write Feedback</string> | ||
| <string name="write_feedback">WRITE A FEEDBACK</string> |
There was a problem hiding this comment.
Okay. I just follow the play store for UI.
There was a problem hiding this comment.
Button text is automatically capitalized
There was a problem hiding this comment.
Yes right sorry. I have changed it for text view.
There was a problem hiding this comment.
Not capitalizing with that style. Added an extra attribute.
|
Updated |
| android:id="@+id/feedbackBtn" | ||
| style="@style/ThreeDS2TextButtonStyle" | ||
| android:textAllCaps="true" | ||
| android:textAlignment="center" |
4 participants
Fixes #2175
Fixes #2184