feat: Add delete account feature #2115
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| |}]""".trimMargin().replace("'", "\"") | ||
|
|
||
| compositeDisposable += eventService.getEventsOfUser(authService.getId(), query) | ||
| .withDefaultSchedulers() |
There was a problem hiding this comment.
This is not your job. This is server's job
There was a problem hiding this comment.
I thought frontend also did the same. There is no endpoint to check whether an account is deletable or not, so we have to check whether there are active events attached to the account from client-side or not
There was a problem hiding this comment.
So should I just proceed to delete and then when server return delete fail, I'll display the message that there are events attached so the account is not deletable?
liveHarshit
reviewed
Jul 17, 2019
app/src/main/java/org/fossasia/openevent/general/auth/ProfileFragment.kt
Show resolved
Hide resolved
|
Reopening as mistakenly closed |
liveHarshit
approved these changes
Jul 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #2114
Screenshots for the change:
