Skip to content

chore: Use correct Mapbox Java SDK version #2089

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 10, 2019
Merged

chore: Use correct Mapbox Java SDK version #2089

merged 1 commit into from
Jul 10, 2019

Conversation

@ShridharGoel
Copy link
Member

Fixes #2088

@auto-label auto-label bot added the fix label Jul 9, 2019
liveHarshit
liveHarshit reviewed Jul 9, 2019
View reviewed changes
Copy link
Member

@liveHarshit liveHarshit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How the project was syncing with the gradle files earlier if the version is not available?

@ShridharGoel
Copy link
Member Author

How the project was syncing with the gradle files earlier if the version is not available?

It wasn't syncing so I checked and got to know that the version is not available. It was updated few days back (#2049). Don't know how Travis build is passing.

liveHarshit
liveHarshit previously approved these changes Jul 9, 2019
View reviewed changes
nikit19
nikit19 previously approved these changes Jul 9, 2019
View reviewed changes
iamareebjamal
iamareebjamal requested changes Jul 9, 2019
View reviewed changes
Copy link
Member

@iamareebjamal iamareebjamal left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the latest version is 4.8.0, how did dependabot update it to 4.9.0 and how did the builds succeed?

All builds are still succeeding

@iamareebjamal
Copy link
Member

https://travis-ci.org/fossasia/open-event-attendee-android/builds/553816252?utm_source=github_status&utm_medium=notification

@ShridharGoel ShridharGoel dismissed stale reviews from nikit19 and liveHarshit via 1676a13 July 9, 2019 20:33
@ShridharGoel ShridharGoel changed the title fix: Use correct Mapbox Java SDK version chore: Use correct Mapbox Java SDK version Jul 9, 2019
@auto-label auto-label bot added chore and removed fix labels Jul 9, 2019
@ShridharGoel
Copy link
Member Author

ShridharGoel commented Jul 9, 2019 •
edited by unfurl-links bot
Loading

If the latest version is 4.8.0, how did dependabot update it to 4.9.0 and how did the builds succeed?

All builds are still succeeding

Yes but isn't building locally. Would be good if anyone can confirm.
Check the latest release version: https://github.com/mapbox/mapbox-java/releases

GitHub
The Mapbox Java SDK – Java wrappers around Mapbox APIs and other location data - mapbox/mapbox-java

@iamareebjamal
Copy link
Member

They have not tagged a release but released it on maven. Paste the error you're getting building locally

@ShridharGoel
Copy link
Member Author

Paste the error you're getting building locally

ERROR: Failed to resolve: com.mapbox.mapboxsdk:mapbox-sdk-services:4.9.0

@iamareebjamal iamareebjamal merged commit 68cadfb into fossasia:development Jul 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iamareebjamal iamareebjamal iamareebjamal requested changes

+2 more reviewers

@nikit19 nikit19 nikit19 left review comments

@liveHarshit liveHarshit liveHarshit left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

chore

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Fix Mapbox Java SDK version

4 participants

@ShridharGoel @iamareebjamal @nikit19 @liveHarshit