feat: Add filtering and sorting dialog #2069
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Details: - Add filtering and sorting orders Fixes: #2028
anhanh11001
changed the title
liveHarshit
reviewed
Jul 5, 2019
What do you mean by merged? If it is about having the same Fragment than I'm not sure because they have different layouts |
Only the toolbar layout is different which can be hidden. But okay it will be complex, needs to handle navigation bar also. |
liveHarshit
approved these changes
Jul 5, 2019
|
Open an issue to make the label small as it will look truncated on almost all devices |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details:
Fixes: #2028
Screenshots for the change:
