Skip to content

chore: Simplify signing apk, update apk generation and README #2040

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 4, 2019
Merged

chore: Simplify signing apk, update apk generation and README #2040

merged 2 commits into from
Jul 4, 2019

Conversation

@liveHarshit
Copy link
Member

@liveHarshit liveHarshit commented Jul 1, 2019 •
edited
Loading

@auto-label auto-label bot added the chore label Jul 1, 2019
ShridharGoel
ShridharGoel reviewed Jul 1, 2019
View reviewed changes
@iamareebjamal
Copy link
Member

Change apk update scripts as well

@liveHarshit liveHarshit changed the title chore: Update readme for with new repo name chore: Update apk generation and readme Jul 2, 2019
@liveHarshit
Copy link
Member Author

liveHarshit commented Jul 2, 2019 •
edited
Loading

@iamareebjamal Please review the changes. And I'm not able to test the script.

@iamareebjamal
Copy link
Member

Will do

@mariobehling
Copy link
Member

@liveHarshit This issue can be easily solved in the same PR, I think: #658

Could you please solve this as well here?

@liveHarshit
Copy link
Member Author

liveHarshit commented Jul 2, 2019 •
edited
Loading

@liveHarshit This issue can be easily solved in the same PR, I think: #658

Could you please solve this as well here?

Yes, I have solved it in this PR, forgot to mention in fixes.

@liveHarshit liveHarshit changed the title chore: Update apk generation and readme [Test] chore: Update apk generation and readme Jul 2, 2019
@auto-label auto-label bot removed the chore label Jul 2, 2019
@mariobehling
Copy link
Member

It is not solved. Please read the issue carefully. Please pay attention to detail. It would be awesome if we could reach a better quality of PRs where mentors don't have to give feedback again and again. Please help to save everyone time.

adityastic
adityastic reviewed Jul 2, 2019
View reviewed changes
adityastic
adityastic reviewed Jul 2, 2019
View reviewed changes
@adityastic
Copy link
Contributor

Also remove the unaligned version. Use this as an example fossasia/badgemagic-app#422

@liveHarshit liveHarshit changed the title [Test] chore: Update apk generation and readme chore: Update apk generation and readme Jul 2, 2019
@auto-label auto-label bot added the chore label Jul 2, 2019
ghost
ghost previously approved these changes Jul 2, 2019
View reviewed changes
@iamareebjamal
Copy link
Member

@liveHarshit Please make the changes shown in this PR as well fossasia/open-event-organizer-android#1770

@liveHarshit
Copy link
Member Author

liveHarshit commented Jul 2, 2019 •
edited
Loading

@iamareebjamal okay 👍 . Is everything right with current changes?

@iamareebjamal
Copy link
Member

Not seen yet. Many changes will be unnecessary after the changes I have made. unsigned and unaligned APK will not be generated, so there'll be no need of removing. And so on...

@liveHarshit
Copy link
Member Author

@iamareebjamal Updated

@liveHarshit liveHarshit changed the title chore: Update apk generation and readme chore: Simplify signing apk, update apk generation and README Jul 2, 2019
iamareebjamal
iamareebjamal reviewed Jul 3, 2019
View reviewed changes
iamareebjamal
iamareebjamal reviewed Jul 3, 2019
View reviewed changes
scripts/update-apk.sh Outdated
/bin/rm -f open-event-attendee-master-app-playStore-release.apk open-event-attendee-master-app-fdroid-release.apk open-event-attendee-master-app-playStore-debug.apk open-event-attendee-master-app-fdroid-debug.apk
else
/bin/rm -f open-event-dev-app-fdroid-debug.apk open-event-dev-app-playStore-debug.apk open-event-dev-app-playStore-release.apk open-event-dev-app-fdroid-release.apk
/bin/rm -f open-event-attendee-dev-app-fdroid-debug.apk open-event-attendee-dev-app-playStore-debug.apk open-event-attendee-dev-app-playStore-release.apk open-event-attendee-dev-app-fdroid-release.apk
Copy link
Member

@iamareebjamal iamareebjamal Jul 3, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

open-event-attendee-dev-*

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated

@liveHarshit liveHarshit requested a review from iamareebjamal July 3, 2019 16:56
@iamareebjamal
Copy link
Member

No change in prep key has been made

@liveHarshit
Copy link
Member Author

No change in prep key has been made

Updated

@iamareebjamal iamareebjamal merged commit 82a44ae into fossasia:development Jul 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iamareebjamal iamareebjamal iamareebjamal approved these changes

+3 more reviewers

@adityastic adityastic adityastic left review comments

@ShridharGoel ShridharGoel ShridharGoel left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

chore

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Update APK generation and follow name conventions

5 participants

@liveHarshit @iamareebjamal @mariobehling @adityastic @ShridharGoel