-
Couldn't load subscription status.
- Fork 554
feat: Add create/load speaker profile for user #1816
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add create/load speaker profile for user #1816
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please complete one WIP PR before sending another.
|
@nikit19 Yes, I understand it, and both current WIP PR I'm sending take me more time then I expected, but I'll make sure I finish them as soon as possible, hopefully around today evening. I sent them to let the mentors and other contributors know that I'm still making some progress |
|
@nikit19 @iamareebjamal Do you know how to make a filter in making GET request. I'm trying to take a speaker under event and user by this: or But both of this return a list of speakers under user without filtering the event ID given. |
|
There's no filter applied and the query itself is wrong. Why are you querying |
|
But you haven't applied any filter |
|
So putting this |
|
There is no filter in the query. Adding event in the query will just make it
Also you are using encoded EventId and not an int, which will result in God knows what How filters work if shown in Search section of the app. Please take a look at that |
|
Updated: Description above @liveHarshit Please review |
| var event: EventId? = null, | ||
| @ColumnInfo(index = true) | ||
| @Relationship("user") | ||
| var user: UserId? = null |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These all should be value not variables, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is email field editable?
And you can use progress dialog instead of progress bar from utils.
Details: - Create fragment/ViewModel to create/get current speaker profile for fragment Fixes: #1811
|
Updated, I have used progress dialog, it looks better; enable email editing (at first I thought the frontend set is as disabled); turned variables to values |
| | }, { | ||
| | 'name':'email', | ||
| | 'op':'eq', | ||
| | 'val':'${user.email}' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is the email thingy needed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
I think you can remove the email from the filter. Rest is fine |




Details:
Fixes: #1811
Screenshots for the change:
