Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor typo fixes #529

Merged
merged 2 commits into from
Nov 12, 2019
Merged

Minor typo fixes #529

merged 2 commits into from
Nov 12, 2019

Conversation

RajChowdhury240
Copy link
Member

@RajChowdhury240 RajChowdhury240 commented Nov 6, 2019

Fixes #528

Changes:
Corrected Few minor spelling mistakes in README file

Screenshot/s for the changes:
Image

Checklist: [Please tick following check boxes with [x] if the respective task is completed]

  • I have used resources from strings.xml, dimens.xml and colors.xml without hard-coding them
  • No modifications done at the end of resource files strings.xml, dimens.xml or colors.xml
  • I have reformatted code in every file included in this PR [CTRL+ALT+L]
  • My code does not contain any extra lines or extra spaces
  • I have requested reviews from other members

APK for testing: [Compress the app-debug.apk file into a <feature>.rar or <feature>.zip file and upload it here]

@dipu989
Copy link
Contributor

dipu989 commented Nov 7, 2019

@Rajchowdhury420 Also, fill information in the template of the PR correctly.
Take a look at fossasia/pslab-android#1993.

Copy link
Member Author

@RajChowdhury240 RajChowdhury240 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed Minor typos

@RajChowdhury240
Copy link
Member Author

@dipu989 check nah

@mariobehling
Copy link
Member

Thanks. We need to move forward with the functionality though right now. Improving typos can also be done as part of improving functionality. Please help to focus on code.

Copy link
Member

@jddeep jddeep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Let us move from here. Please focus on features and code for now.

@jddeep jddeep merged commit d660dcd into fossasia:development Nov 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Typing Erors in README
4 participants