Remove polymorphic monads #219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
delikat
reviewed
Aug 7, 2018
| func NearestVCS(dirname string) (vcsType cli.VCS, vcsDir string, err error) { | ||
| vcsDir, err = files.WalkUp(dirname, func(d string) error { | ||
| tool, err := vcsIn(d) | ||
| func Nearest(dirname string) (VCS, string, error) { |
There was a problem hiding this comment.
👍 to this and other renames
delikat
reviewed
Aug 7, 2018
| // containing the directory, or ErrNoNearestVCS if none is found. | ||
| func NearestVCS(dirname string) (vcsType cli.VCS, vcsDir string, err error) { |
There was a problem hiding this comment.
Why the move away from named returns?
There was a problem hiding this comment.
I just avoid them where possible, because assignment in Go follows unintuitive shadowing rules. I usually only use named returns when returning multiple values of the same type.
Example of weird shadowing:
func Foo() (bar string) {
bar, err := Baz() // This is a _different_ bar, shadowing the original
return // Implicitly returns `bar = ""`, the string type's zero value
}- Documentation on named returns
- More shadowing examples:
delikat
approved these changes
Aug 7, 2018
elldritch
force-pushed
the
refactor/210-monomorphic-monads
branch
from
ab5c1cd
to
d638517
Compare
meghfossa
pushed a commit
that referenced
this pull request
Nov 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #210.