Various fixes and enhancements #889

niol · 2017-03-14T12:48:16Z

Details are in the individual patches.

This should fix fossar#756 and give a workaround for other cookie related issues.

jtojnar · 2017-03-14T13:31:26Z

public/js/selfoss-ui.js

+     * @param message string
+     */
+    showError: function(message) {
+        selfoss.ui.showMessage(message, 'undefined', 'undefined', true);


This should probably be quote-less, since typeof 'undefined' === 'string', leading to showing button with undefined text in error messages (e.g. invalid fragment like #invalid)

jtojnar · 2017-03-14T15:25:44Z

I am not sure if #879 should be fixed right now, since it is a BC break. I will ask Tobias about BC break policy.

jtojnar · 2017-03-14T15:57:56Z

For now, it would be probably better to leave out the commit since we are essentially on 2.17 feature freeze.

jtojnar · 2017-03-14T16:20:22Z

There is still some work to do, for example, tags key in /items endpoint should be an array of tags; separate pull request will probably be for the best.

jtojnar · 2017-03-14T20:38:41Z

Another issue with the async refresh: refreshing on the sources page will keep loading forever with the error selfoss.lastUpdate is null in the console.

jtojnar · 2017-03-14T21:12:44Z

Another point against the API change: 4eb1891 breaks adding sources.

jtojnar · 2017-03-14T21:34:17Z

controllers/Sources.php

@@ -165,7 +165,7 @@ public function write() {
        unset($data['ajax']);

        // check if source already exists
-        $id = \F3::get('PARAMS["id"]');
+        $id = intval(\F3::get('PARAMS["id"]'));


This breaks the source adding since intval('new-123') === 0, which is a valid ID according to $sourcesDao->isValid.

jtojnar · 2017-03-14T21:35:16Z

daos/mysql/Sources.php

@@ -144,13 +144,15 @@ public function get($id = null) {
        // select source by id if specified or return all sources
        if (isset($id)) {
            $ret = \F3::get('db')->exec('SELECT id, title, tags, spout, params, filter, error FROM ' . \F3::get('db_prefix') . 'sources WHERE id=:id', [':id' => $id]);
+            $this->stmt->ensureRowTypes($ret, ['id' => \PDO::PARAM_INT]);


This should be assigned to $ret.

jtojnar · 2017-03-14T21:35:22Z

daos/mysql/Sources.php

            if (isset($ret[0])) {
                $ret = $ret[0];
            } else {
                $ret = false;
            }
        } else {
            $ret = \F3::get('db')->exec('SELECT id, title, tags, spout, params, filter, error FROM ' . \F3::get('db_prefix') . 'sources ORDER BY error DESC, lower(title) ASC');
+            $this->stmt->ensureRowTypes($ret, ['id' => \PDO::PARAM_INT]);


This should be assigned to $ret.

jtojnar · 2017-03-14T21:37:27Z

public/css/style.css

+#message a {
+    font-size:0.9em;
+    text-align:center;
+    -moz-border-radius:2px;


No need for prefixed versions, since border-radius is widely supported.

The prefixed border-radius was removed everywhere but here.

jtojnar · 2017-03-14T22:19:29Z

Additionally, 00ced63 broke error handling when adding source. Try adding http://example.com as an RSS feed with no title: the server will correctly return error but client will keep loading.

jtojnar · 2017-03-14T22:59:55Z

public/js/selfoss-base.js

@@ -261,7 +264,7 @@ var selfoss = {
                since:          selfoss.lastUpdate.toISOString(),
                tags:           true,
                sources:        selfoss.filter.sourcesNav,
-                items_statuses: true
+                items_statuses: selfoss.lastUpdate !== null


Won’t this now always be true, since there is line 256?

…w) 2 remove last prefixed border radius

jtojnar · 2017-03-15T08:47:24Z

Rebased and merged as 6beba94

The overflow was initially enabled for preformatted text and blockquotes in 77b09ef but it was somewhat quizzically reverted in #674 and then reintroduced for <pre> in #889. This time we are enabling it for the tables and removing the forgotten blockquote code.

use base_url in config for cookie options

3aabd6e

This should fix fossar#756 and give a workaround for other cookie related issues.

jtojnar reviewed Mar 14, 2017

View reviewed changes

jtojnar added api bc break bug toolchain ui labels Mar 14, 2017

niol added 6 commits March 14, 2017 20:47

show proposed diff in syntax checker

a16cfd2

fix pgsql useless sql row types conversion

8219b63

fix <pre> scroll

65ff554

Make it more apparent refreshing sources has finished (fossar#881)

73dc0ef

unbreak scroll_to_article_header=0

f2f1f0c

fix action shown on error message

6d1d9f7

jtojnar requested changes Mar 14, 2017

View reviewed changes

fix going directly to sources and doing a manual refresh

b0de59e

niol added 2 commits March 14, 2017 23:33

cleanup CSS prefixed border-radius properties (as widely supported now)

d97c56a

fix typo (unfortunate search/replace in showError function refactor

71e2fb5

niol force-pushed the ppr/fixqueue branch from bd0cb2a to 71e2fb5 Compare March 14, 2017 22:40

jtojnar reviewed Mar 14, 2017

View reviewed changes

jtojnar added ux and removed api bc break labels Mar 14, 2017

niol added 2 commits March 15, 2017 09:05

cleanup CSS prefixed border-radius properties (as widely supported no…

17b047f

…w) 2 remove last prefixed border radius

do not download all item statuses when no items have been loaded

0c1d2bc

jtojnar approved these changes Mar 15, 2017

View reviewed changes

jtojnar closed this Mar 15, 2017

jtojnar mentioned this pull request Mar 15, 2017

Mark as read button or option to disable scroll on item open #685

Closed

jtojnar mentioned this pull request Nov 27, 2017

fix blockquote and pre overflow-x resetting #674

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Various fixes and enhancements #889

Various fixes and enhancements #889

niol commented Mar 14, 2017

jtojnar Mar 14, 2017 •

edited

Loading

jtojnar commented Mar 14, 2017

jtojnar commented Mar 14, 2017

jtojnar commented Mar 14, 2017 •

edited

Loading

jtojnar commented Mar 14, 2017

jtojnar commented Mar 14, 2017

jtojnar Mar 14, 2017 •

edited

Loading

jtojnar Mar 14, 2017

jtojnar Mar 14, 2017

jtojnar Mar 14, 2017

jtojnar Mar 14, 2017

jtojnar commented Mar 14, 2017

jtojnar Mar 14, 2017 •

edited

Loading

jtojnar commented Mar 15, 2017 •

edited

Loading

Various fixes and enhancements #889

Various fixes and enhancements #889

Conversation

niol commented Mar 14, 2017

jtojnar Mar 14, 2017 • edited Loading

Choose a reason for hiding this comment

jtojnar commented Mar 14, 2017

jtojnar commented Mar 14, 2017

jtojnar commented Mar 14, 2017 • edited Loading

jtojnar commented Mar 14, 2017

jtojnar commented Mar 14, 2017

jtojnar Mar 14, 2017 • edited Loading

Choose a reason for hiding this comment

jtojnar Mar 14, 2017

Choose a reason for hiding this comment

jtojnar Mar 14, 2017

Choose a reason for hiding this comment

jtojnar Mar 14, 2017

Choose a reason for hiding this comment

jtojnar Mar 14, 2017

Choose a reason for hiding this comment

jtojnar commented Mar 14, 2017

jtojnar Mar 14, 2017 • edited Loading

Choose a reason for hiding this comment

jtojnar commented Mar 15, 2017 • edited Loading

jtojnar Mar 14, 2017 •

edited

Loading

jtojnar commented Mar 14, 2017 •

edited

Loading

jtojnar Mar 14, 2017 •

edited

Loading

jtojnar Mar 14, 2017 •

edited

Loading

jtojnar commented Mar 15, 2017 •

edited

Loading