Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

a11y and usability fixes #1134

Merged
merged 18 commits into from
Sep 25, 2019
Merged

a11y and usability fixes #1134

Changes from 1 commit
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
8459dd9
a11y: improve login form
Sep 22, 2019
b05a332
a11y: Add aria-label to buttons
Sep 22, 2019
f78d9fd
client: Drop branding from the sidebar
jtojnar Sep 23, 2019
d0c0ff5
a11y: Make sidebar links more accessible
Sep 22, 2019
fb98d92
a11y: many more small a11y fixes
Sep 22, 2019
3ad1fdb
a11y: Convert entry toolbars to lists
Sep 22, 2019
0c2de8b
a11y: change metadata
Sep 23, 2019
7ed6303
a11y: improve metadata on OPML & hashpashword pages
Sep 23, 2019
6a09b57
a11y: Improve sources page
Sep 23, 2019
4c9b6be
a11y: Add accesskeys
Sep 23, 2019
504a8c9
a11y: Added autocomplete=new-password to the hashpassword template
Sep 23, 2019
fd68a81
a11y: add ARIA labels to nav lists
Sep 23, 2019
492c4be
a11y: Add label for the entry action list
Sep 24, 2019
fc22251
a11y: Add access keys for the 'source form'
Sep 24, 2019
f87549e
a11y: Add some more access keys
Sep 24, 2019
9fa3a89
client: refactor aria-expanded manipulation to function calls
jtojnar Sep 24, 2019
d4e362d
client: refactor entry selection
jtojnar Sep 24, 2019
d089773
a11y: add aria-current to the selected item
jtojnar Sep 24, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
a11y: Improve sources page 
Fixed some issues in sources.phtml template. made the favicon hidden by aria-hidden="true" because alt="" is not a efficient practise.
  • Loading branch information
@jtojnar
Akash Kakkar authored and jtojnar committed Sep 25, 2019
commit 6a09b57d267f16f4e7779e2653241efccdc0d8a7
6 changes: 3 additions & 3 deletions templates/source.phtml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
class="source <?= isset($this->source) === false ? 'source-new' : '' ?> <?= (isset($this->source) && isset($this->source['error']) && strlen($this->source['error']) > 0) ? 'error' : '' ?>">
<div class="source-icon">
<?php if (isset($this->source) && isset($this->source['icon']) && $this->source['icon'] != '0') : ?>
<img src="<?= 'favicons/' . $this->source['icon']; ?>" alt="" />
<img src="<?= 'favicons/' . $this->source['icon']; ?>" aria-hidden="true" alt="" />
<?php endif; ?>
</div>

Expand Down Expand Up @@ -81,14 +81,14 @@

<!-- error messages -->
<?php if (isset($this->source) && isset($this->source['error'])) : ?>
<li class="source-error">
<li class="source-error" aria-live="assertive">
<?= $this->source['error']; ?>
</li>
<?php endif; ?>

<!-- save/delete -->
<li class="source-action">
<button class="source-save"><?= \F3::get('lang_source_save')?></button> &bull; <button class="source-cancel"><?= \F3::get('lang_source_cancel')?></button>
<button class="source-save" accesskey="s"><?= \F3::get('lang_source_save')?></button> &bull; <button class="source-cancel" accesskey="c"><?= \F3::get('lang_source_cancel')?></button>
</li>
</ul>

Expand Down