-
Notifications
You must be signed in to change notification settings - Fork 344
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
A couple minor things #1305
Comments
|
the thin scrollbar in 2.18 works in chromium-based browsers from what I've seen |
Yeah, in 2.18 we used a custom JavaScript library which worked in most browsers but sometimes it bugged out. And also it was based on jQuery, which we are trying to get rid of. Tried but will change it to that. |
Make it closer to 2.18 style (45px). Mentioned in #1305
The JavaScript based custom scrollbars are often buggy. But the default Chromium scrollbar is ugly. Let’s bring the look closer to 2.18 by using -webkit-scrollbar pseudoelement. It needs to be thicker than in Firefox because Webkit does not support capturing nearby mouse events. Mentioned in #1305
I switched it to a ::-webkit-scrollbar based approach, which looks slightly less ugly (thought not as nice as 2.18). |
looks like the checks errored at linting |
Oops, I realized that a second after I pushed it and then forgot to push the fix. |
Only thing I'm struggling with is CSS tweaking so the bar isn't green on my plex theme. In theory, it should just be: .nav-ts-wrapper {
&::-webkit-scrollbar-thumb {
background: var(--button-color);
}
&::-webkit-scrollbar-thumb:hover {
background: var(--button-color);
}
&::-webkit-scrollbar-thumb:active {
background: var(--button-color-hover);
}
} |
The .nav-ts-wrapper::-webkit-scrollbar-thumb {
background: var(--button-color);
}
.nav-ts-wrapper::-webkit-scrollbar-thumb:hover {
background: var(--button-color);
}
.nav-ts-wrapper::-webkit-scrollbar-thumb:active {
background: var(--button-color-hover);
} |
thanks, that works, I was probably just to tired staring at it yesterday! |
Version Number missing
In 2.18
In 2.19
Button sizes
As per the above images, both scaled the same, 2.19 buttons seem large
Scroll Bar in 2.18 is nicer looking
In 2.18
In 2.19
The text was updated successfully, but these errors were encountered: