Skip to content

Fix empty Select Model button when no model is selected #957

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
heyshreenanda wants to merge 1 commit into
base: main
Choose a base branch
from
+11 −2
Open

Fix empty Select Model button when no model is selected #957

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions lib/screens/common_widgets/ai/ai_model_selector_button.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ class AIModelSelectorButton extends StatelessWidget {
final bool useRootNavigator;
final VoidCallback? onDialogOpen;
final VoidCallback? onDialogClose;

const AIModelSelectorButton({
super.key,
this.aiRequestModel,
Expand All @@ -22,12 +23,15 @@ class AIModelSelectorButton extends StatelessWidget {

@override
Widget build(BuildContext context) {
final modelName = aiRequestModel?.model;

return ElevatedButton(
onPressed: readonly
? null
: () async {
onDialogOpen?.call();
final newAIRequestModel = await showDialog(

final newAIRequestModel = await showDialog<AIRequestModel>(
context: context,
useRootNavigator: useRootNavigator,
builder: (context) {
Expand All @@ -40,11 +44,16 @@ class AIModelSelectorButton extends StatelessWidget {
);
},
);

onDialogClose?.call();
if (newAIRequestModel == null) return;
onModelUpdated?.call(newAIRequestModel);
},
child: Text(aiRequestModel?.model ?? 'Select Model'),
child: Text(
(modelName != null && modelName.isNotEmpty)
? modelName
: 'Select Model',
),
);
}
}