Fix cursor jumping in URL field with proper selection handling (#924) #952
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Preserve cursor and text selection during URL edits - Dispose TextEditingController correctly to prevent memory leaks - Fix syntax issue in ExtendedTextField - Add widget tests for cursor and selection preservation Fixes foss42#924
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR improves upon the fix introduced in PR #925 for issue #924
(cursor jumping to the end when editing URLs).
While PR #925 resolved the main cursor issue, Copilot review identified
follow-up concerns which are addressed here.
Improvements over PR #925
Related PRs
Tests
Added widget tests covering:
All tests pass locally.
Fixes #924