fix: prevent null crash on empty JWT private key (#1703)#1706
Open
deepak0x wants to merge 1 commit into
Open
Conversation
privateKey is nullable in AuthJwtModel; restore `?? jwt.privateKey` fallback instead of force-unwrapping substituteVariables() result. Add regression test for null privateKey. Closes foss42#1703
deepak0x
force-pushed
the
fix/jwt-private-key-null-crash
branch
from
8c3966a to
7da78a6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Description
AuthJwtModel.privateKeyis nullable (String?), butsubstituteAuthModel()inlib/utils/envvar_utils.dartforce-unwraps the result ofsubstituteVariables(jwt.privateKey, envVarMap)!. SincesubstituteVariables()returnsnullfornullinput, using JWT auth without a private key crashes with "Null check operator used on a null value."This restores the safe
?? jwt.privateKeyfallback forprivateKey.secretandpayloadkeep!since they arerequired String(non-nullable) and cannot be null.Related Issues
Checklist
mainbranch before making this PRflutter upgradeand verify)flutter test) and all tests are passingAdded/updated tests?
test/utils/envvar_utils_test.dart. Verified locally on Flutter 3.44.4 / Dart 3.12.2 — all tests intest/utils/envvar_utils_test.dartpass.OS on which you have developed and tested the feature?