Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updating crichton reference #29

Merged
merged 2 commits into from
Oct 6, 2014
Merged

updating crichton reference #29

merged 2 commits into from
Oct 6, 2014

Conversation

brutski
Copy link
Collaborator

@brutski brutski commented Sep 24, 2014

@fosrias please merge. Updating Gemfile to point to the latest crichton making crichton-demo-service work again.

@@ -3,7 +3,7 @@ source 'https://rubygems.org'
# Bundle edge Rails instead: gem 'rails', github: 'rails/rails'
gem 'rails', '3.2.0'

gem 'crichton', git: 'git@github.com:mdsol/crichton.git', tag: '0.0.3'
gem 'crichton', git: 'git@github.com:brutski/crichton.git', tag: '0.0.3'
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@HonoreDB So, given the making crichton private and the comments on the demo service, where are we? Are you guys just planning to fork this and use it internally? Any issues with this commit. Effectively this won't work without @brutski's change here.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fosrias @HonoreDB as far as I remember they dropped supporting/using it. Instead it was planned to use blueprint.

@fosrias
Copy link
Owner

fosrias commented Sep 27, 2014

@brutski I forked current mdsol-share repo here: https://github.com/fosrias/crichton. What do you think about keeping this all in this repo? If so, how about updating the gemfile and maybe fixing the links in the README of crichton pointing here (or I can). Thanks for this and sorry I am slow to this. Tied up at RESTfest.

@fosrias
Copy link
Owner

fosrias commented Sep 27, 2014

@brutski Fixed docs myself: https://github.com/fosrias/crichton/pulls/1

@brutski
Copy link
Collaborator Author

brutski commented Oct 2, 2014

@fosrias so I looked at your branch of crichton. Exactly what I was talking today: don't really like the latest commit, which adds descriptor_type element to API doc. My feeling is that it is trying to solve errors profile rdlint validation problem. So, I suggest you fork crichton from my repo into yours.
Also, I think, solution to this problem can be implemetation of exclusion list for rdlint, so we can exclude certain sections from being validated. As if it were a story: As an API doc developer, I should be able to exclude certain sections from being validated. Perfect use case: I've implemented only semantics section of the doc and want to know if it is valid or not. Thoughts?

@fosrias
Copy link
Owner

fosrias commented Oct 2, 2014

So, if things work should we leave it for now. They may change this and it would make it easier to pull over new releases if they happen. I agree it is less than optimal. Thoughts?

On Oct 1, 2014, at 7:25 PM, brutski notifications@github.com wrote:

@fosrias so I looked at your branch of crichton. Exactly what I was talking today: don't really like the latest commit, which adds descriptor_type element to API doc. My feeling is that it is trying to solve errors profile rdlint validation problem. So, I suggest you fork crichton from my repo into yours.
Also, I think, solution to this problem can be implemetation of exclusion list for rdlint, so we can exclude certain sections from being validated. As if it were a story: As an API doc developer, I should be able to exclude certain sections from being validated. Perfect use case: I've implemented only semantics section of the doc and want to know if it is valid or not.


Reply to this email directly or view it on GitHub.

@brutski
Copy link
Collaborator Author

brutski commented Oct 6, 2014

@fosrias crichton-demo-service works. updated PR to point to git@github.com:fosrias/crichton.git; v.0.0.3

@fosrias
Copy link
Owner

fosrias commented Oct 6, 2014

@brutski Thx. Merging.

fosrias added a commit that referenced this pull request Oct 6, 2014
@fosrias fosrias merged commit b240a15 into master Oct 6, 2014
@fosrias fosrias deleted the update_crichton_gem_path branch October 6, 2014 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants