Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ESLint pass #140

Merged
merged 2 commits into from
May 9, 2024
Merged

ESLint pass #140

merged 2 commits into from
May 9, 2024

Conversation

TylerVigario
Copy link
Collaborator

@TylerVigario TylerVigario commented Apr 27, 2024

Overview

The Focus of this PR is to ensure our ESLint configuration reflects the latest best practices.

Changes

  • Migrate to Kebab case (example-file.js) for all filenames except for language files that will only accept RFC 5646 (en-US.js)
  • Add eslint-plugin-unicorn and enable recommended config
  • 1st pass of migrating towards conditional action comments (TODO, FIXME, etc)
  • Lint all .js files in root directory, not just bench.js
  • Fix lint issues that arose during changes

@TylerVigario TylerVigario changed the title Add eslint-plugin-unicorn ESLint pass Apr 28, 2024
@TylerVigario
Copy link
Collaborator Author

I'll follow up when the remaining plugins support ESLint v9. But for now, I will merge this to keep ahead of the curve.

@TylerVigario TylerVigario merged commit c51e5f3 into forzagreen:master May 9, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant