Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump to 1.19 #131

Merged
merged 1 commit into from
Feb 8, 2024
Merged

Bump to 1.19 #131

merged 1 commit into from
Feb 8, 2024

Conversation

TylerVigario
Copy link
Collaborator

No description provided.

@TylerVigario TylerVigario merged commit 0ec8d63 into forzagreen:master Feb 8, 2024
3 checks passed
@forzagreen
Copy link
Owner

Hi @TylerVigario, Thank for the new updates !

Could you please build and push package-lock.json ? because the publish workflow gets the package version and dependencies from package-lock.json using npm ci:

Also, there is an error in the step npm run build:types: https://github.com/forzagreen/n2words/actions/runs/7824354103
I am able to reproduce it locally, but I haven't had the opportunity to resolve it yet.

[node_modules/@types/node/globals.d.ts#L6](https://github.com/forzagreen/n2words/commit/e21496df297af90e7a0574937cbd3314c957889f#annotation_17828709934)
Cannot find module 'undici-types'. Did you mean to set the 'moduleResolution' option to 'nodenext', or to add aliases to the 'paths' option?

@TylerVigario
Copy link
Collaborator Author

I commit package-lock with dependency updates. See - #130

I'll take a look at the error in generating typings.

@forzagreen
Copy link
Owner

Make sure the package-lock.json contains the correct package version to be deployed (1.19.0)

@TylerVigario
Copy link
Collaborator Author

TylerVigario commented Feb 9, 2024

Make sure the package-lock.json contains the correct package version to be deployed (1.19.0)

😆 That makes sense. I'll get that updated as well.

EDIT: I finally got that sorted out 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants