Skip to content

Conversation

@nahtnam
Copy link
Contributor

@nahtnam nahtnam commented Aug 18, 2024

Checklist

Same issue with the HTML preview as the text preview. Fixes #36

  • I have ensured my pull request is not behind the main or master branch of the original repository.
  • I have rebased all commits where necessary so that reviewing this pull request can be done without having to merge it first.
  • I have written a commit message that passes commitlint linting.
  • I have ensured that my code changes pass linting tests.
  • I have ensured that my code changes pass unit tests.
  • I have described my pull request and the reasons for code changes along with context if necessary.

@nahtnam nahtnam force-pushed the fix-popups-for-html branch from 854cf78 to e913394 Compare August 18, 2024 01:06
@nahtnam nahtnam changed the title Update template.pug to allow popups in the html version fix(template): update template.pug to allow popups in the html version Aug 18, 2024
@nahtnam
Copy link
Contributor Author

nahtnam commented Aug 18, 2024

cc @titanism, this is ready!

@titanism titanism merged commit 670b781 into forwardemail:master Aug 18, 2024
@nahtnam nahtnam deleted the fix-popups-for-html branch August 18, 2024 01:15
@titanism
Copy link
Contributor

v3.1.0 released to npm

https://github.com/forwardemail/test-preview-emails-cross-browsers-ios-simulator-nodejs-javascript/releases/tag/v3.1.0

thank you @nahtnam 🙏

we use this in @forwardemail and this will be a nice addition

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[fix] Links in previews don't open on click

2 participants