Add meshgrid subroutine in stdlib_math
#764
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WIP: first_proposal
igirault
changed the title
meshgrid subroutine in stdlib_math
jvdp1
reviewed
Feb 8, 2024
Member
jvdp1
left a comment
jvdp1
left a comment
There was a problem hiding this comment.
Thank you for this PR.
I am not familiar with this. However, the specs, code and tests seem to be good to me. I have only a few suggestions.
Co-authored-by: Jeremie Vandenplas <jeremie.vandenplas@gmail.com>
Co-authored-by: Jeremie Vandenplas <jeremie.vandenplas@gmail.com>
Co-authored-by: Jeremie Vandenplas <jeremie.vandenplas@gmail.com>
jvdp1
approved these changes
Feb 18, 2024
Member
jvdp1
left a comment
jvdp1
left a comment
There was a problem hiding this comment.
LGTM. Thank you @Ivanou34 for this PR.
Member
|
Thank you @perazz for your review. I will fix the conflict ( in a CMake file) and merge it. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP: first_proposal
The PR implements
meshgrid, based on the API described in #18. It includes tests, spec and examples.All versions for
integerandrealtypes are generated with fypp, as well as multi-dimensional versions, from 1 up to the maximum rank allowed.The use of the subroutine
error_stopin the case of invalid argumentindexingprevented me to declare the subroutine with thepureattribute.