Add symmetric tridiagonal matrices module#1091
Add symmetric tridiagonal matrices module#1091Mahmood-Sinan wants to merge 13 commits intofortran-lang:masterfrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1091 +/- ##
==========================================
- Coverage 68.55% 68.50% -0.06%
==========================================
Files 396 397 +1
Lines 12746 12753 +7
Branches 1376 1376
==========================================
- Hits 8738 8736 -2
- Misses 4008 4017 +9 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
It looks pretty nice. One little thing though (even if I overlooked it when implementing the I'll go through the code a bit more thoroughly tomorrow but it looks pretty good to me already. |
Thanks for the suggestion! You’re right, I implemented so. Now the tridiagonal and symtridiagonal construction is now handled by two pure helper routines(one from arrays and one from constants), which is called by both the pure and impure constructors. |
loiseaujc
left a comment
There was a problem hiding this comment.
I'll take a deeper look at it by the end of the week, but it looks quite good to me so far.
| implicit none | ||
| private | ||
| public :: tridiagonal | ||
| public :: tridiagonal, sym_tridiagonal |
There was a problem hiding this comment.
Modulo this very style question, I think it's pretty much all good for me !
This draft PR adds support for symmetric tridiagonal matrices inside
specialmatricesin stdlib.It includes implementation, tests, documentation and examples.
The PR implements the same arithmetic and matrix operations as the existing tridiagonal module.
Remaining tasks:
(this will be added here once that implementation is merged).
Feedback is welcome.