Should reverse be in stdlib_string?

[ivan-pi]

#310 added the reverse function to the stdlib_ascii module. Since the behavior of this function does not depend on the character set, the stdlib_string module would be a better home for it.

On the other hand the overloaded functions to_lower, to_upper, and to_title for the string_type(currently in stdlib_string_type) do implement behavior depending on the character set, and should be placed in stdlib_ascii.

cc @awvwgk

[awvwgk]

There is an issue with cyclic dependencies here. Moving reverse from stdlib_ascii to stdlib_strings requires to move the implementation in stdlib_string_type as well, same of to_lower, to_upper and to_title. Now that we have a stdlib_strings module we could think about reshuffling the procedures, leaving only inquiry functions in stdlib_ascii, the type definition + overloaded intrinsics in stdlib_string_type and everything related to string manipulation is moved to stdlib_strings.

[aniket2405]

Hello, I would like to work on this issue, if available. Thanks!

[awvwgk]

Feel free to submit a patch for this issue. If you have any questions regarding stdlib and the workflow, do not hesitate to ask, we are always happy to help.

[Pranavchiku]

I feel it is implemented here: https://github.com/fortran-lang/stdlib/blob/master/src/stdlib_ascii.fypp#L336-L346, is there anything else we need for this issue?

Edit: Ahh I see, it is aimed to migrate reverse, to_lower, ... , from stdlib_ascii to stdlib_string.

[Merothiya]

I'd like to work on this issue if it is still available. Thanks.

[jvdp1]

@Merothiya Thank you for your interest. AFAIK this issue is still available. Some work have been done (e.g., #745 ), but not finished.