Add thread safety (OpenMP critical) to command registration #1143
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mand registration
zoziha
changed the title
Merged
perazz
approved these changes
May 17, 2025
There was a problem hiding this comment.
Well done @zoziha, LGTM. This is absolutely necessary as the compile_commands_t structure is shared across threds during openmp builds.
Let's merge this before the new release. I wonder if next, a test can be established for openmp builds?
Yes, it is necessary to add CI testing of fpm for omp parallel building later. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I was testing the compilation of fpm in MSYS2, after enabling
--flag "-fopenmp", I found that this could cause the compilation of fpm projects by the generated fpm to be interrupted with a certain probability. I realized that this should be related to the build process and OpenMP. I traced this situation back to the "addcompile_commands_table_tto the build backend" commit. I found that the problem is caused by the race condition writing oftable%command(intent(inout)).fpm/src/fpm_backend.F90
Line 325 in fd1b1f8
This commit is recommended to be merged before the fpm 0.12.0 is released.