Do not require parentheses for the defined preprocessor operator
#67
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #67 +/- ##
==========================================
+ Coverage 81.69% 81.71% +0.02%
==========================================
Files 9 9
Lines 4338 4338
==========================================
+ Hits 3544 3545 +1
+ Misses 794 793 -1
Continue to review full report at Codecov.
|
|
Awesome @phil-blain, thanks for the contribution. I will add a unittest and I think this is ready to merge. |
|
I checked the tests before submitting and saw there was no tests yet for |
The regex that checks for preprocessor macros using the 'defined' operator assumes that the macro that follows the operator is between parenthesis. However, the syntax for the 'defined' operator does not require parenthesis, at least in GNU Cpp [1] and Intel fpp [2], arguably the two most commonly used Fortran preprocessors. Tweak the regex by allowing the opening and closing parenthesis zero or once. [1] https://gcc.gnu.org/onlinedocs/gcc-10.2.0/cpp/Defined.html#Defined [2] https://software.intel.com/content/www/us/en/develop/documentation/fortran-compiler-oneapi-dev-guide-and-reference/top/optimization-and-programming-guide/fpp-preprocessing/using-fpp-preprocessor-directives.html
gnikit
force-pushed
the
pp-defined-without-parens
branch
from
5fc1c14 to
fe9d389
Compare
|
Thanks @phil-blain for the contribution. Your fix is now available in version 2.2.5 available for download through PyPi |
|
Super ! Thanks for the added test:) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The regex that checks for preprocessor macros using the 'defined'
operator assumes that the macro that follows the operator is between
parenthesis. However, the syntax for the 'defined' operator does not
require parenthesis, at least in GNU Cpp [1] and Intel fpp [2], arguably
the two most commonly used Fortran preprocessors.
Tweak the regex by allowing the opening and closing parenthesis zero or
once.
[1] https://gcc.gnu.org/onlinedocs/gcc-10.2.0/cpp/Defined.html#Defined
[2] https://software.intel.com/content/www/us/en/develop/documentation/fortran-compiler-oneapi-dev-guide-and-reference/top/optimization-and-programming-guide/fpp-preprocessing/using-fpp-preprocessor-directives.html