Skip to content

Issue #286: Fix wrong indentation of derived type #305

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
Jul 23, 2023
Merged

Issue #286: Fix wrong indentation of derived type #305

merged 14 commits into from
Jul 23, 2023

Conversation

folk85
Copy link
Contributor

@folk85 folk85 commented Jul 9, 2023

refuse spaces in middle of derived types, add one test

@folk85 folk85 requested a review from gnikit as a code owner July 9, 2023 16:34
@codecov
Copy link

codecov bot commented Jul 9, 2023 •
edited
Loading

Codecov Report

Merging #305 (2d88bfa) into master (039131b) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #305   +/-   ##
=======================================
  Coverage   86.98%   86.98%           
=======================================
  Files          12       12           
  Lines        4580     4581    +1     
=======================================
+ Hits         3984     3985    +1     
  Misses        596      596
Impacted Files Coverage Δ
fortls/helper_functions.py 97.75% <100.00%> (+0.01%) ⬆️

gnikit
gnikit requested changes Jul 9, 2023
View reviewed changes
Copy link
Member

@gnikit gnikit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't change or invalidate existing tests for a modification.
None of the existing tests should have to change line numbers/column numbers.
You can add a test to demonstrate the issue that is being solved.

Also, please link to the corresponding Issue.

@gnikit gnikit marked this pull request as draft July 9, 2023 17:12
@gnikit
Copy link
Member

gnikit commented Jul 9, 2023

I am converting this to a draft. Please mark as ready for review when the PR is ready.

@folk85
Copy link
Contributor Author

folk85 commented Jul 9, 2023

@gnikit , Sorry, You are right, I turn back modified tests and add new one for current Issue. As I understood it's enough just to add new commit without any additional manipulations.

@folk85 folk85 requested a review from gnikit July 11, 2023 09:15
@gnikit gnikit linked an issue Jul 16, 2023 that may be closed by this pull request
Type fields or methods are not detected if spaces are used around % #286
Closed
gnikit
gnikit requested changes Jul 19, 2023
View reviewed changes
Copy link
Member

@gnikit gnikit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update with relevant comments and slim down the test case, to only test the unit of code introduced.
Also update the CHANGELOG, with a matching style and descriptions as the other entries under
Fixed.

@gnikit gnikit marked this pull request as ready for review July 19, 2023 22:21
gnikit
gnikit approved these changes Jul 23, 2023
View reviewed changes
Copy link
Member

@gnikit gnikit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I updated the docstring, since they are used as unit tests.
I will merge once the checks pass.

@gnikit gnikit merged commit 1873065 into fortran-lang:master Jul 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gnikit gnikit gnikit approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Type fields or methods are not detected if spaces are used around %
2 participants
@folk85 @gnikit