Skip to content

ISSUE-1077: addcomputer: add SAMR_LDAP finalization mode#2179

Open
herbenderbler wants to merge 1 commit into
fortra:masterfrom
herbenderbler:ISSUE-1077/samr-set-machine
Open

ISSUE-1077: addcomputer: add SAMR_LDAP finalization mode#2179
herbenderbler wants to merge 1 commit into
fortra:masterfrom
herbenderbler:ISSUE-1077/samr-set-machine

Conversation

@herbenderbler
Copy link
Copy Markdown
Contributor

  • Add explicit SAMR_LDAP method to examples/addcomputer.py.
  • Keep existing SAMR behavior unchanged for SMB-only environments.
  • After SAMR account creation, finalize dnsHostName and servicePrincipalName over LDAPS.
  • Fail the SAMR_LDAP flow if LDAP finalization cannot be completed.

@jagotu
Copy link
Copy Markdown
Contributor

jagotu commented Apr 28, 2026

I didn't test if it works, but I don't see any issue with the approach.

I would still consider exposing a "finalization-only" mode, so for example if you did a SAMR-only addcomputer from a relay, you can finalize the account using addcomputer.py with the computer's credentials (given they have enough access rights).

@herbenderbler herbenderbler force-pushed the ISSUE-1077/samr-set-machine branch from e8c4fb7 to 9d1db8a Compare April 29, 2026 16:41
@herbenderbler
Copy link
Copy Markdown
Contributor Author

I didn't test if it works, but I don't see any issue with the approach.

I tested locally and also added regression testing to keep this in place. Let me know if this is overkill and/or if I missed the mark somewhere.

I would still consider exposing a "finalization-only" mode, so for example if you did a SAMR-only addcomputer from a relay, you can finalize the account using addcomputer.py with the computer's credentials (given they have enough access rights).

I just pushed a new finalization-only mode. Like before, let me know if this doesn't land with you and I can rework what I wrote.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants