ISSUE-1077: addcomputer: add SAMR_LDAP finalization mode#2179
ISSUE-1077: addcomputer: add SAMR_LDAP finalization mode#2179herbenderbler wants to merge 1 commit into
Conversation
|
I didn't test if it works, but I don't see any issue with the approach. I would still consider exposing a "finalization-only" mode, so for example if you did a SAMR-only addcomputer from a relay, you can finalize the account using addcomputer.py with the computer's credentials (given they have enough access rights). |
e8c4fb7 to
9d1db8a
Compare
I tested locally and also added regression testing to keep this in place. Let me know if this is overkill and/or if I missed the mark somewhere.
I just pushed a new finalization-only mode. Like before, let me know if this doesn't land with you and I can rework what I wrote. |
SAMR_LDAPmethod toexamples/addcomputer.py.SAMRbehavior unchanged for SMB-only environments.dnsHostNameandservicePrincipalNameover LDAPS.SAMR_LDAPflow if LDAP finalization cannot be completed.