Skip to content

Conversation

@ldemailly
Copy link
Member

@ldemailly ldemailly commented Sep 12, 2025

I thought I did this in #7 but didn't / got side tracked so here it is

@codecov
Copy link

codecov bot commented Sep 12, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (fb8b190) to head (3d170ac).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main        #8   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         1           
  Lines          189       195    +6     
=========================================
+ Hits           189       195    +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ldemailly ldemailly requested a review from Copilot September 12, 2025 00:24
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes the dependency on the unicode package and reverts the Go version requirement from 1.21 back to 1.20. The changes replace unicode package functions with custom helper functions and substitute the built-in min function (introduced in Go 1.21) with explicit comparison logic.

  • Replaces unicode.IsLetter() with custom character checking logic
  • Substitutes min() function with manual comparison
  • Adds helper functions for character classification

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
go.mod Downgrades Go version requirement from 1.21 to 1.20
duration.go Removes unicode import, adds helper functions, and replaces min() with manual comparison

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@ldemailly ldemailly merged commit 52d8dad into main Sep 12, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant