Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Nov 26, 2025

Code review identified a bug where getGlobalBinPath() returned binDir instead of globalBinDir, plus inconsistent ObjectMapper instantiation patterns.

Bug Fix

  • ToolInstallationDescriptor.getGlobalBinPath(): Was returning wrong field
// Before (incorrect)
public Path getGlobalBinPath() {
    return asPath(binDir);
}

// After (correct)
public Path getGlobalBinPath() {
    return asPath(globalBinDir);
}

Code Consistency

  • AbstractToolListCommand, AbstractToolGetCommand: Replaced new ObjectMapper() with JsonHelper.getObjectMapper() to match existing pattern in AbstractToolInstallCommand and AbstractToolUninstallCommand

Merge Conflict Notes

5 files will conflict when merging to dev/v3.x:

File Resolution
AbstractFoDDastAutomatedScanSetupCommand.java Combine: SLF4J (dev/v3.x) + TypeReference import (PR)
FoDReleaseAssessmentTypeHelper.java Combine: SLF4J (dev/v3.x) + Predicate import + FcliSimpleException (PR)
ci.yaml (generic/fod/ssc) Both changes target different sections, straightforward merge

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Copilot AI and others added 2 commits November 26, 2025 03:56
Co-authored-by: rsenden <8635138+rsenden@users.noreply.github.com>
…bjectMapper()

Co-authored-by: rsenden <8635138+rsenden@users.noreply.github.com>
Copilot AI changed the title [WIP] Update tool and CI integration logic Fix ToolInstallationDescriptor.getGlobalBinPath() and standardize ObjectMapper usage Nov 26, 2025
Copilot AI requested a review from rsenden November 26, 2025 04:06
@rsenden rsenden marked this pull request as ready for review December 9, 2025 10:26
@rsenden rsenden merged commit 473cb94 into feat/ci-updates Dec 9, 2025
@rsenden rsenden deleted the copilot/sub-pr-867-another-one branch December 9, 2025 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants