forked from Azure/azure-rest-api-specs
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
This reverts commit c92693a.
- Loading branch information
Showing
6,626 changed files
with
16,030 additions
and
902,688 deletions.
The diff you're trying to view is too large. We only load the first 3000 changed files.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,7 +1,63 @@ | ||
# Choose a PR Template | ||
<i>MSFT employees can try out our new experience at <b>[OpenAPI Hub](https://aka.ms/openapiportal) </b> - one location for using our validation tools and finding your workflow. | ||
</i> | ||
Azure 1st Party Service can try out the [Shift Left](https://aka.ms/ShiftLeft) experience to initiate API design review from ADO code repo. If you are interested, may request engineering support by filling in with the form https://aka.ms/ShiftLeftSupportForm. | ||
|
||
Switch to "Preview" on this description then select one of the choices below. | ||
### Changelog | ||
Add a changelog entry for this PR by answering the following questions: | ||
1. What's the purpose of the update? | ||
- [ ] new service onboarding | ||
- [ ] new API version | ||
- [ ] update existing version for new feature | ||
- [ ] update existing version to fix swagger quality issue in s360 | ||
- [ ] Other, please clarify | ||
2. When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month. | ||
3. When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month. | ||
4. If updating an existing version, please select the specific language SDKs and CLIs that must be refreshed after the swagger is published. | ||
- [ ] SDK of .NET (need service team to ensure code readiness) | ||
- [ ] SDK of Python | ||
- [ ] SDK of Java | ||
- [ ] SDK of Js | ||
- [ ] SDK of Go | ||
- [ ] PowerShell | ||
- [ ] CLI | ||
- [ ] Terraform | ||
- [ ] No refresh required for updates in this PR | ||
|
||
<a href="?expand=1&template=data_plane_template.md">Click here</a> to open a PR for a Data Plane API. | ||
### Contribution checklist: | ||
- [ ] I commit to follow the [Breaking Change Policy](http://aka.ms/bcforapi) of "no breaking changes" | ||
- [ ] I have reviewed the [documentation](https://aka.ms/ameonboard) for the workflow. | ||
- [ ] [Validation tools](https://aka.ms/swaggertools) were run on swagger spec(s) and errors have all been fixed in this PR. [How to fix?](https://aka.ms/ci-fix) | ||
|
||
<a href="?expand=1&template=control_plane_template.md">Click here</a> to open a PR for a Control Plane (ARM) API. | ||
If any further question about AME onboarding or validation tools, please view the [FAQ](https://aka.ms/faqinprreview). | ||
|
||
### ARM API Review Checklist | ||
|
||
> **Applicability**: :warning: | ||
> | ||
> If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review. | ||
> - Change to data plane APIs | ||
> - Adding new properties | ||
> - All removals | ||
Otherwise your PR may be subject to ARM review requirements. Complete the following: | ||
- [ ] Check this box if any of the following appy to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment. | ||
- Adding a new service | ||
- Adding new API(s) | ||
- Adding a new API version | ||
-[ ] To review changes efficiently, ensure you are using OpenAPIHub to initialize the PR for adding a new version. More details, refer to the [wiki](https://dev.azure.com/azure-sdk/internal/_wiki/wikis/internal.wiki/208/OpenAPI-Hub-Adding-new-API-version). | ||
|
||
- [ ] Ensure you've reviewed following [guidelines](https://aka.ms/rpguidelines) including [ARM resource provider contract](https://github.com/Azure/azure-resource-manager-rpc) and [REST guidelines](https://github.com/microsoft/api-guidelines/blob/vNext/azure/Guidelines.md). Estimated time (4 hours). This is required before you can request review from ARM API Review board. | ||
|
||
- [ ] If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (*RP Manifest Approvers* team under <ins>Azure Resource Manager service</ins>) from IcM and reach out to them. | ||
|
||
### Breaking Change Review Checklist | ||
If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the [Breaking Change Policy](http://aka.ms/bcforapi). | ||
- [ ] Removing API(s) in a stable version | ||
- [ ] Removing properties in a stable version | ||
- [ ] Removing API version(s) in a stable version | ||
- [ ] Updating API in a stable or public preview version with Breaking Change Validation errors | ||
- [ ] Updating API(s) in public preview over 1 year (refer to [Retirement of Previews](https://dev.azure.com/msazure/AzureWiki/_wiki/wikis/AzureWiki.wiki/37683/Retirement-of-Previews)) | ||
|
||
**Action**: to initiate an evaluation of the breaking change, create a new intake using the [template for breaking changes](https://aka.ms/Breakingchangetemplate). Addition details on the process and office hours are on the [Breaking change Wiki](https://dev.azure.com/msazure/AzureWiki/_wiki/wikis/AzureWiki.wiki/37684/Breaking-Changes). | ||
|
||
Please follow the link to find more details on [PR review process](https://aka.ms/SwaggerPRReview). |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Validating CODEOWNERS rules …
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.