Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New components: DataTable + variants #103

Merged
merged 39 commits into from
Jan 17, 2025
Merged

Conversation

imadbakir
Copy link
Collaborator

No description provided.

@imadbakir imadbakir requested review from mkrause and nighto January 14, 2025 06:41
@mkrause mkrause changed the title Feature/component data table New components: DataTable + variants Jan 14, 2025
Copy link
Collaborator

@mkrause mkrause left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like sorting by "Joined" in the various stories is not working correctly.

Screenshot 2025-01-14 at 17 20 47

Copy link
Collaborator

@mkrause mkrause left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some props are leaking into the DOM:

Screenshot 2025-01-14 at 17 22 06

Copy link
Collaborator

@mkrause mkrause left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a tabindex="0" on the table, I guess that's because of potential of horizontal scrolling?

Screenshot 2025-01-14 at 17 22 54

I guess that's fine. Maybe if you could put an example of a table with horizontal scroll.

Copy link
Collaborator

@mkrause mkrause left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's no animation on the skeleton loader currently. Would be good to put something like a shimmer effect on there.

Screenshot 2025-01-14 at 17 24 56

Copy link
Collaborator

@mkrause mkrause left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The loading spinner here should overlay the whole table.

Screenshot 2025-01-14 at 17 27 20

@imadbakir
Copy link
Collaborator Author

There's a tabindex="0" on the table, I guess that's because of potential of horizontal scrolling?

Screenshot 2025-01-14 at 17 22 54

I guess that's fine. Maybe if you could put an example of a table with horizontal scroll.

This was tricky to do, I tried to but couldn't do it right now, it's either problematic (buggy) or, just difficult to do within so many scrolling contexts and view-ports etc.. (being in story book canvas etc..), this has to be looked at later.

@imadbakir imadbakir requested a review from mkrause January 15, 2025 10:00
src/components/tables/DataTable/DataTableEager.stories.tsx Outdated Show resolved Hide resolved
src/components/tables/DataTable/DataTableEager.tsx Outdated Show resolved Hide resolved
src/components/tables/DataTable/DataTableEager.scss Outdated Show resolved Hide resolved
src/components/tables/DataTable/DataTableLazy.stories.tsx Outdated Show resolved Hide resolved
src/components/tables/DataTable/pagination/Pagination.scss Outdated Show resolved Hide resolved
src/components/tables/MultiSearch/MultiSearch.scss Outdated Show resolved Hide resolved
src/components/tables/SearchInput/SearchInput.scss Outdated Show resolved Hide resolved
src/components/tables/util/hooks.ts Outdated Show resolved Hide resolved
@imadbakir imadbakir requested a review from mkrause January 17, 2025 02:27
@mkrause mkrause merged commit 1913efc into master Jan 17, 2025
3 checks passed
@mkrause mkrause deleted the feature/component-data-table branch January 17, 2025 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants