Skip to content

Conversation

jonasnick
Copy link
Member

@jonasnick jonasnick commented May 5, 2025

bitcoin: 28.1 -> 29.0
bitcoind: 28.1 -> 29.0
btcpayserver: 2.0.7 -> 2.1.0
clightning: 24.11.1 -> 25.02.1
fulcrum: 1.11.1 -> 1.12.0.1
nbxplorer: 2.5.23 -> 2.5.25

This currently doesn't build because the clnrest python plugin has been removed from clightning. It now ships with a rust implementation of the clnrest plugin (now called rest-plugin).

CC @erikarvstedt

jonasnick and others added 2 commits May 5, 2025 12:40
bitcoin: 28.1 -> 29.0
bitcoind: 28.1 -> 29.0
btcpayserver: 2.0.7 -> 2.1.0
clightning: 24.11.1 -> 25.02.1
fulcrum: 1.11.1 -> 1.12.0.1
nbxplorer: 2.5.23 -> 2.5.25
@erikarvstedt
Copy link
Collaborator

Here's my WIP branch to complete this PR.

This option is unneeded because `bitcoin-cli` auth and connection
settings are already provided by other options like `bitcoin-rpcpassword`.

In bitcoind versions prior to 29.0, option `datadir` (passed by clightning to `bitcoin-cli`)
was therefore ignored.
Since 29.0, option `datadir` is always checked for validity. This causes a
file permission error because service clighting has no access to the
bitcoin datadir. This is now fixed.
Unneded because the timeout has been increased upstream:
ElementsProject/lightning@ee3133f
@erikarvstedt
Copy link
Collaborator

My branch is ready for review.

@jonasnick
Copy link
Member Author

Concept ACK so far, thanks @erikarvstedt!

@erikarvstedt erikarvstedt marked this pull request as ready for review May 9, 2025 13:47
Copy link
Collaborator

@erikarvstedt erikarvstedt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 411b131

@jonasnick jonasnick merged commit b2bc5e6 into fort-nix:master May 9, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants