Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chinese translation #813

Merged
merged 2 commits into from
Aug 7, 2024
Merged

Chinese translation #813

merged 2 commits into from
Aug 7, 2024

Conversation

jamesliu96
Copy link
Contributor

resolved todos

#680 #681

@forrestguice forrestguice added this to the v0.16.1 milestone Aug 7, 2024
@forrestguice forrestguice added translation zh_TW Traditional Chinese zh_CN Simplified Chinese labels Aug 7, 2024
@@ -876,7 +876,7 @@
<string name="sunevent_title">太阳</string> <!-- (custom) sun event title; e.g. "Sun 6°" -->
<string name="sunevent_title_format">%1$s %2$s</string> <!-- (custom) sun event title; e.g. "Sun 6°" -->
<string name="sunevent_summary_format"><xliff:g id="title">%1$s</xliff:g> 于 <xliff:g id="angle">%2$s</xliff:g></string> <!-- (custom) sun event summary; e.g. "Sun 6°" -->
<string name="sunevent_phrase_gender">其他</string> <!-- either 'other' or 'female' (SelectFormat api) -->
Copy link
Owner

@forrestguice forrestguice Aug 7, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These _gender values are unusual. Translations can override them, but the expected value is always 'other' or 'female', which allows matching gender/plurality between some noun and its articles.

For example, offset_before_msg1 defines
{0} before {1, plural, one {{2, select, female {} other {}}} other {{2, select, female {} other {}}}}{3}
(which is basically empty / does nothing).

The Spanish version then overrides this with {0} antes {1, plural, one {{2, select, female {de la} other {del}}} other {{2, select, female {de las} other {de los}}}} {3}. The provided _gender determines if this prints de la <noun> vs del <noun>, etc.

https://developer.android.com/reference/android/icu/text/SelectFormat
Its really confusing in my opinion, and since most languages don't seem to need them, I'll probably comment them out everywhere.

@forrestguice
Copy link
Owner

Thank you.

@forrestguice forrestguice merged commit 5239d17 into forrestguice:master Aug 7, 2024
1 check passed
@forrestguice forrestguice mentioned this pull request Aug 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
translation zh_CN Simplified Chinese zh_TW Traditional Chinese
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants