Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Arabic translation #786

Merged
merged 8 commits into from
Apr 5, 2024
Merged

Add Arabic translation #786

merged 8 commits into from
Apr 5, 2024

Conversation

mstfelg
Copy link
Contributor

@mstfelg mstfelg commented Apr 1, 2024

Thank you for this handy app.

@forrestguice
Copy link
Owner

Thanks for the contribution. ❤️
I will review/merge this later today, and then tag v0.15.14 over the weekend.
It should be on F-Droid sometime next week.

cleans up duplicates values
adds Arabic to locale credits
cleans up translatable="false" values
adds missing plurals; `ar` needs plurals for `zero`, `two`, `few`, and `many` (TODO)
@forrestguice forrestguice added this to the v0.15.14 milestone Apr 4, 2024
@forrestguice
Copy link
Owner

I've reviewed this and made a few minor fixes. This looks good. 👍

There is one problem remaining though - lint complains that ar requires a complete set of plurals (zero, one, two, few, many, other). This can be a little confusing since each locale has its own rules (e.g. many locales only need one and many), or they use the rules in peculiar ways (e.g. I think Russian uses the one rule for any value that contain a 1).

Anyhow, I'm not certain what the rules are for Arabic , so I've added untranslated lines for those values (now marked TODO).
I'll leave this open a few more days before merging (if you want to amend it).

Once the translation is published, it can be update whenever you'd like, and I'll tag another patch version (on a 2-3 week cycle).

irregular `units_days` plural passes a String; should contain %s instead of %d
@forrestguice forrestguice mentioned this pull request Apr 4, 2024
@forrestguice forrestguice merged commit a3dcc77 into forrestguice:master Apr 5, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants